From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8571 invoked by alias); 6 Aug 2003 13:04:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8541 invoked from network); 6 Aug 2003 13:04:03 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 6 Aug 2003 13:04:03 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19kNxI-0006ht-7o; Wed, 06 Aug 2003 09:03:52 -0400 Date: Wed, 06 Aug 2003 13:04:00 -0000 From: Daniel Jacobowitz To: Kei Sakamoto Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error Message-ID: <20030806130352.GA25689@nevyn.them.org> Mail-Followup-To: Kei Sakamoto , gdb-patches@sources.redhat.com References: <028801c35a51$47db96d0$5169910a@KEI> <20030805180235.GA30002@nevyn.them.org> <009b01c35bbc$dff15420$5169910a@KEI> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <009b01c35bbc$dff15420$5169910a@KEI> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00078.txt.bz2 On Wed, Aug 06, 2003 at 10:48:46AM +0900, Kei Sakamoto wrote: > > Two minor things: > > - You accidentally sent a reversed diff. > > - ChangeLog formatting. It should be: > > > > 2003-08-04 Kei Sakamoto > > > > * gdb.asm/m32r.inc: Add several missing symbols. Replace ld24 > > with seth/add3. > > Sorry about that. > > > One less minor thing: no other port needs to declare symbols. It looks > > like part of libc is being dragged in somehow on m32r; could you > > explain why the symbols are necessary? > > asm-source is compiled with -nostartfiles. So gcc does not use libgloss.a. > But on m32r, somehow several system calls, _write, etc., are included > in it. So it is necessary to declare these symbols. On other architectures, > these system calls are included in libc.a, which is not removed > by -nostartfiles. > > Unfortunately, I don't know why m32r's libgloss is different from others. > Should I modify libgloss and newlib rather than declare symbols in m32r.inc? -nostartfiles should prevent the inclusion of crt* but not of libgloss; libgloss is a matter for -nostdlib, which we _don't_ use. I see that in the m32r GCC port, -lgloss is in ENDFILE_CPU_SPEC, which is unlike any other port. I don't want to mess with that right now, but does adding -lgloss to ${link-flags} in asm-source.exp fix the problem? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer