Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: [rfa/6.0] Fix a thinko in dwarf2loc
Date: Fri, 01 Aug 2003 19:32:00 -0000	[thread overview]
Message-ID: <20030801193245.GA2529@nevyn.them.org> (raw)

Any variable with DW_OP_reg* requires a frame to read it - what
symbol_read_needs_frame () really means is "is this variable meaningful when
the program is not running".

This would show up in the testsuite, but GCC doesn't tend to put locals in
registers without optimization or register keywords everywhere.  Symptom is
that a watchpoint was not deleted when we left its scope, since we thought
it was global.

OK?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2003-08-01  Daniel Jacobowitz  <drow@mvista.com>

	* dwarf2loc.c (dwarf2_loc_desc_needs_frame): Variables in a
	register do need a frame.

--- gdb-5.3.20030801/gdb/dwarf2loc.c.orig	2003-08-01 14:58:57.000000000 -0400
+++ gdb-5.3.20030801/gdb/dwarf2loc.c	2003-08-01 15:00:05.000000000 -0400
@@ -318,7 +318,7 @@ dwarf2_loc_desc_needs_frame (unsigned ch
 
   free_dwarf_expr_context (ctx);
 
-  return baton.needs_frame;
+  return baton.needs_frame || ctx->in_reg;
 }
 
 static void


             reply	other threads:[~2003-08-01 19:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-01 19:32 Daniel Jacobowitz [this message]
2003-08-17 20:58 ` Daniel Jacobowitz
2003-08-24 16:48   ` Daniel Jacobowitz
2003-09-07  4:12     ` Daniel Jacobowitz
2003-09-09 21:18       ` Elena Zannoni
2003-09-09 21:25         ` Daniel Jacobowitz
2003-09-09 22:45           ` Elena Zannoni
2003-09-09 22:59             ` Andrew Cagney
2003-09-11 15:50               ` Daniel Jacobowitz
2003-09-11 17:16                 ` Elena Zannoni
2003-09-11 17:17                   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030801193245.GA2529@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox