From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1117 invoked by alias); 16 Jul 2003 09:51:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1110 invoked from network); 16 Jul 2003 09:51:47 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 16 Jul 2003 09:51:47 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h6G9plH01277 for ; Wed, 16 Jul 2003 05:51:47 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h6G9pkS28634 for ; Wed, 16 Jul 2003 05:51:46 -0400 Received: from cygbert.vinschen.de (vpn50-1.rdu.redhat.com [172.16.50.1]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h6G9piK28118 for ; Wed, 16 Jul 2003 02:51:45 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id D6C56580A2; Wed, 16 Jul 2003 11:51:42 +0200 (CEST) Date: Wed, 16 Jul 2003 09:51:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Improvements for sh double register display Message-ID: <20030716095142.GG1733@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <3F031E03.3040206@redhat.com> <16148.21516.843971.449438@localhost.redhat.com> <3F148155.9010602@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F148155.9010602@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-07/txt/msg00319.txt.bz2 On Tue, Jul 15, 2003 at 03:33:57PM -0700, Michael Snyder wrote: > Elena Zannoni wrote: > >Michael Snyder writes: > > > 2003-07-02 Michael Snyder > > > > > > * sh-tdep.c (do_dr_register_info): Fix register number output > > > (0, 2, 4, ... not 0, 1, 2...). Display DP register both in > > > hex and in floating point (noting when it is not valid FP). > > > > > > Index: sh-tdep.c > > > =================================================================== > > > RCS file: /cvs/src/src/gdb/sh-tdep.c,v > > > retrieving revision 1.132 > > > diff -p -r1.132 sh-tdep.c > > > *** sh-tdep.c 13 Jun 2003 04:40:34 -0000 1.132 > > > --- sh-tdep.c 2 Jul 2003 18:00:22 -0000 > > > *************** static void > > > *** 3928,3938 **** > > > do_dr_register_info (int dr_regnum) > > > { > > > int first_fp_reg_num = dr_reg_base_num (dr_regnum); > > > > > > ! printf_filtered ("dr%d\t0x%08x%08x\n", > > > ! dr_regnum - gdbarch_tdep (current_gdbarch)->DR0_REGNUM, > > > ! (int) read_register (first_fp_reg_num), > > > ! (int) read_register (first_fp_reg_num + 1)); > > > } > > > > > > /* Double precision registers, compact mode. */ > > > --- 3928,3962 ---- > > > do_dr_register_info (int dr_regnum) > > > { > > > int first_fp_reg_num = dr_reg_base_num (dr_regnum); > > > + char *raw_buffer; > > > + double dbl; > > > + int inv; > > > > > > ! /* Allocate space for the float. */ > > > ! raw_buffer = (char *) alloca (2 * REGISTER_RAW_SIZE (FP0_REGNUM)); > > > >Can you use something other than alloca here? Also, this will collide > >in mid air with Corinna's revamp. Maybe you can revisit this after she > >is done? Otherwise it's ok. > > OK, I'll touch space-helmets with Corinna. > BTW, what's wrong with alloca? Since I've applied my patch, that should be ok now. Btw., REGISTER_RAW_SIZE isn't implemented on sh anymore ;-) Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc. mailto:vinschen@redhat.com