Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: kettenis@chello.nl
Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [patch, rfc, 6.0] Change frame predicates to sniffers
Date: Mon, 14 Jul 2003 05:35:00 -0000	[thread overview]
Message-ID: <200307140534.h6E5Yw6U012469@duracef.shout.net> (raw)

Mark Kettenis writes:
> For your testcases, the instructions after the function call are
> optimized away.  This means that the return address of the called
> frame points to the first instruction of the next function.  The
> prologue analysis is done for this function instead of the function
> that actually made the call.

Gotcha.

> The new prologue analyzer notices that at the first instruction of a
> function, the frame-pointer hasn't been setup yet, and the frame
> unwinder uses the stack-pointer for unwinding.  This fails because we
> haven't actually called the function we're analyzing.

Aha!

This is consistent with the stack dump I attached to pr gdb/1250.
gdb picks out a word for the program counter that would be correct
if the caller looked like this:

  func2:
    call abort
    push %ebp
    mov %ebp, %esp

This is a good candidate for a standalone test, gdb.base/gdb1250.exp,
with a KFAIL in it.  I'll write such a test tomorrow.

Michael C


             reply	other threads:[~2003-07-14  5:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-14  5:35 Michael Elizabeth Chastain [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-07-12 19:19 Michael Elizabeth Chastain
2003-07-13 16:55 ` Mark Kettenis
2003-07-15 15:56 ` Andrew Cagney
2003-07-11 21:57 Andrew Cagney
2003-07-15 17:41 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307140534.h6E5Yw6U012469@duracef.shout.net \
    --to=mec@shout.net \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox