From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Fix possible buffer overflow bug in x86_64-tdep.c
Date: Sun, 13 Jul 2003 16:32:00 -0000 [thread overview]
Message-ID: <200307131631.h6DGVkvI098450@elgar.kettenis.dyndns.org> (raw)
The attached fixes a possible buffer overflow in
x86_64_store_return_value().
(Andreas, this was the bug I mentioned to you yesterday).
Andreas forgot to check in his origional patch on the 6.0 release
branch. I'll do so shortly with this fix included.
Checked in.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* x86-64-tdep.c (x86_64_store_return_value): Use an intermediate
buffer when storing double and float varibles into %xmm0.
Index: x86-64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
retrieving revision 1.82
diff -u -p -r1.82 x86-64-tdep.c
--- x86-64-tdep.c 9 Jul 2003 22:10:58 -0000 1.82
+++ x86-64-tdep.c 13 Jul 2003 16:28:14 -0000
@@ -788,7 +788,7 @@ x86_64_store_return_value (struct type *
else if (TYPE_CODE_FLT == TYPE_CODE (type))
{
/* Handle double and float variables. */
- regcache_cooked_write (regcache, X86_64_XMM0_REGNUM, valbuf);
+ regcache_cooked_write_part (regcache, X86_64_XMM0_REGNUM, 0, len, buf);
}
/* XXX: What about complex floating point types? */
else
next reply other threads:[~2003-07-13 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-13 16:32 Mark Kettenis [this message]
2003-07-14 8:55 ` Andreas Jaeger
2003-07-14 19:25 ` Mark Kettenis
2003-07-13 22:09 Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307131631.h6DGVkvI098450@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox