Re: RFA: Actual support for tracing forks on GNU/Linux

Michal Ludvig
2003-08-18T13:11:08Z

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Daniel Jacobowitz told me that:
> On Mon, Aug 18, 2003 at 11:09:53AM +0200, Michal Ludvig wrote:

>>Index: x86-64-linux-nat.c
>>===================================================================
>>RCS file: /cvs/src/src/gdb/x86-64-linux-nat.c,v
>>retrieving revision 1.23.6.2
>>diff -u -p -r1.23.6.2 x86-64-linux-nat.c
>>--- x86-64-linux-nat.c 17 Jul 2003 12:51:55 -0000 1.23.6.2
>>+++ x86-64-linux-nat.c 18 Aug 2003 09:05:51 -0000
>>@@ -347,3 +347,9 @@ ps_get_thread_area (const struct ps_proc
>> return PS_ERR; /* ptrace failed. */
>> }
>>
>>+void
>>+child_post_startup_inferior (ptid_t ptid)
>>+{
>>+ i386_cleanup_dregs ();
>>+ linux_child_post_startup_inferior (ptid);
>>+}
>>
>>Right? OK to apply?
>
> Along with defining LINUX_CHILD_POST_STARTUP_INFERIOR, I assume? Yes,
> this is OK. Sorry about breaking amd64.

Thanks, committed the attached.

Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* (+420) 296.545.373 * http://www.suse.cz

[-- Attachment #2: cpsi-2.diff --]
[-- Type: text/plain, Size: 2145 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.4439.2.107
diff -u -p -r1.4439.2.107 ChangeLog
--- ChangeLog 17 Aug 2003 18:53:12 -0000 1.4439.2.107
+++ ChangeLog 18 Aug 2003 13:08:44 -0000
@@ -1,3 +1,10 @@
+2003-08-18 Michal Ludvig <mludvig@suse.cz>
+
+ * config/i386/nm-x86-64linux.h (LINUX_CHILD_POST_STARTUP_INFERIOR):
+ Define.
+ * i386-linux-nat.c: Include "linux-nat.h".
+ (child_post_startup_inferior): New function.
+
2003-08-17 Daniel Jacobowitz <drow@mvista.com>

* lin-lwp.c (child_wait): Call linux_record_stopped_pid.
Index: x86-64-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-linux-nat.c,v
retrieving revision 1.23.6.2
diff -u -p -r1.23.6.2 x86-64-linux-nat.c
--- x86-64-linux-nat.c 17 Jul 2003 12:51:55 -0000 1.23.6.2
+++ x86-64-linux-nat.c 18 Aug 2003 13:08:44 -0000
@@ -25,6 +25,7 @@
#include "inferior.h"
#include "gdbcore.h"
#include "regcache.h"
+#include "linux-nat.h"

#include "gdb_assert.h"
#include "gdb_string.h"
@@ -347,3 +348,9 @@ ps_get_thread_area (const struct ps_proc
return PS_ERR; /* ptrace failed. */
}

+void
+child_post_startup_inferior (ptid_t ptid)
+{
+ i386_cleanup_dregs ();
+ linux_child_post_startup_inferior (ptid);
+}
Index: config/i386/nm-x86-64linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nm-x86-64linux.h,v
retrieving revision 1.3
diff -u -p -r1.3 nm-x86-64linux.h
--- config/i386/nm-x86-64linux.h 19 Jun 2003 15:04:58 -0000 1.3
+++ config/i386/nm-x86-64linux.h 18 Aug 2003 13:08:44 -0000
@@ -61,4 +61,9 @@ extern unsigned long x86_64_linux_dr_get
/* Override copies of {fetch,store}_inferior_registers in `infptrace.c'. */
#define FETCH_INFERIOR_REGISTERS

+/* `linux-nat.c' and `i386-nat.c' have their own versions of
+ child_post_startup_inferior. Define this to use the copy in
+ `x86-86-linux-nat.c' instead, which calls both. */
+#define LINUX_CHILD_POST_STARTUP_INFERIOR
+
#endif /* NM_X86_64_LINUX_H */