From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28157 invoked by alias); 9 Jul 2003 21:46:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28131 invoked from network); 9 Jul 2003 21:46:00 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 9 Jul 2003 21:46:00 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h69LjPaM000233; Wed, 9 Jul 2003 23:45:25 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h69LjKt3000420; Wed, 9 Jul 2003 23:45:20 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h69LjKDD000417; Wed, 9 Jul 2003 23:45:20 +0200 (CEST) Date: Wed, 09 Jul 2003 21:46:00 -0000 Message-Id: <200307092145.h69LjKDD000417@elgar.kettenis.dyndns.org> From: Mark Kettenis To: drow@mvista.com CC: mludvig@suse.cz, gdb-patches@sources.redhat.com In-reply-to: <20030709180801.GA23865@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 9 Jul 2003 14:08:01 -0400) Subject: Re: [RFA] Re: Analyzing AMD64 corefiles on i386 References: <3F0ABC85.1080700@suse.cz> <200307081445.h68EjBWJ000503@elgar.kettenis.dyndns.org> <3F0BF66A.3080203@suse.cz> <200307091338.h69Dc8u7023807@elgar.kettenis.dyndns.org> <20030709180801.GA23865@nevyn.them.org> X-SW-Source: 2003-07/txt/msg00198.txt.bz2 Date: Wed, 9 Jul 2003 14:08:01 -0400 From: Daniel Jacobowitz > Not as such. We can't allow public functions with the names > supply_gregset and fill_gregset in *-tdep.c files. Therefore these > functions should be renamed, and supply_gregset and fill_gregset > should be kept in your *-nat.c file. You'll probably want to rewrite > those functions such that they call the new functions in *-tdep.c. I don't see the harm. They need to be multi-arched instead of called by name, eventually, but it's no extra work to rename them at that time. Not renaming them makes it impossible to build an i386 native GDB that can also debug amd64. > Personally I wouldn't define all those constants if the only place > where they'll be used is the regmap array, but that's a matter of > taste. I'm guessing it makes it easier to at-a-glance compare with . I did the same thing. That's a valid reason. Probably deserves a comment such that nobody gratuitously re-orders the defines. Mark