From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-25745-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 18367 invoked by alias); 4 Jul 2003 11:56:13 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18319 invoked from network); 4 Jul 2003 11:56:11 -0000
Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212)
  by sources.redhat.com with SMTP; 4 Jul 2003 11:56:11 -0000
Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2])
	by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h64BtSEW007139;
	Fri, 4 Jul 2003 13:55:28 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1])
	by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h64BtRkM009553;
	Fri, 4 Jul 2003 13:55:28 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: (from kettenis@localhost)
	by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h64BtQtp009550;
	Fri, 4 Jul 2003 13:55:26 +0200 (CEST)
Date: Fri, 04 Jul 2003 11:56:00 -0000
Message-Id: <200307041155.h64BtQtp009550@elgar.kettenis.dyndns.org>
From: Mark Kettenis <kettenis@chello.nl>
To: kewarken@qnx.com
CC: gdb-patches@sources.redhat.com
In-reply-to: <06ad01c3342d$c4039e50$0202040a@catdog> (kewarken@qnx.com)
Subject: Re: [Patch 2] Native QNX Neutrino support
References: <001a01c3261c$313284c0$0202040a@catdog> <86ptlfh67k.fsf@elgar.kettenis.dyndns.org> <06ad01c3342d$c4039e50$0202040a@catdog>
X-SW-Source: 2003-07/txt/msg00102.txt.bz2

I finally found the time to review your "take 2".

* Use xstrdup() instead of strdup().

* The function calls in the definitions of the QNX_NODE macro need
  spaces before the '(' just like in normal functions.  Could you turn
  this macro into a function?

* While what Andrew says about not having an XM_FILE is desirable, I
  think we still need xm-i386.h to have the best possible handling of
  floating-point numbers on a native GDB.  If you don't set it,
  unnecessary conversions of floating-point numbers might occur,
  leading to loss of precision.  I'll leave the decision to you.

With those changes, please go ahead and check it in.

Mark