From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23592 invoked by alias); 3 Jul 2003 13:57:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23584 invoked from network); 3 Jul 2003 13:57:34 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 3 Jul 2003 13:57:34 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19Y4bZ-0003tA-00 for ; Thu, 03 Jul 2003 08:58:33 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19Y4aa-0003AT-00 for ; Thu, 03 Jul 2003 09:57:32 -0400 Date: Thu, 03 Jul 2003 13:57:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFC: Some more store.exp failures - tweak the test Message-ID: <20030703135731.GA11555@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030701215538.GA5542@nevyn.them.org> <3F0209A5.9080704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F0209A5.9080704@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-07/txt/msg00067.txt.bz2 On Tue, Jul 01, 2003 at 06:22:29PM -0400, Andrew Cagney wrote: > >This patch fixes the store.exp failures for ARM. Two changes: > > - Change char to signed char, because some patterns match -1. If anyone > > prefers changing the patterns to match 255 would work too. > > Yes, but use something like `typedef signed char charest' so that the > function's pattern doesn't need tweaking. Good idea. Checked in with that change. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2003-07-03 Daniel Jacobowitz * gdb.base/store.c (charest): New typedef. (add_char): Rename to add_charest, update. (wack_char): Rename to wack_charest, update types. Return l + r to keep r live across the call. (wack_short, wack_int, wack_long, wack_longest, wack_float) (wack_double, wack_doublest): Return l + r to keep r live across the call. * gdb.base/store.exp: Accomodate store.c changes. Index: gdb/testsuite/gdb.base/store.c =================================================================== --- gdb.orig/testsuite/gdb.base/store.c 2003-07-01 17:56:38.000000000 -0400 +++ gdb/testsuite/gdb.base/store.c 2003-07-03 09:46:53.000000000 -0400 @@ -7,8 +7,10 @@ function calls within main even when no optimization flags were passed. */ -char -add_char (register char u, register char v) +typedef signed char charest; + +charest +add_charest (register charest u, register charest v) { return u + v; } @@ -61,12 +63,12 @@ add_doublest (register doublest u, regis /* */ -char -wack_char (register char u, register char v) +charest +wack_charest (register charest u, register charest v) { - register char l = u, r = v; - l = add_char (l, r); - return l; + register charest l = u, r = v; + l = add_charest (l, r); + return l + r; } short @@ -74,7 +76,7 @@ wack_short (register short u, register s { register short l = u, r = v; l = add_short (l, r); - return l; + return l + r; } int @@ -82,7 +84,7 @@ wack_int (register int u, register int v { register int l = u, r = v; l = add_int (l, r); - return l; + return l + r; } long @@ -90,7 +92,7 @@ wack_long (register long u, register lon { register long l = u, r = v; l = add_long (l, r); - return l; + return l + r; } long @@ -98,7 +100,7 @@ wack_longest (register longest u, regist { register longest l = u, r = v; l = add_longest (l, r); - return l; + return l + r; } float @@ -106,7 +108,7 @@ wack_float (register float u, register f { register float l = u, r = v; l = add_float (l, r); - return l; + return l + r; } double @@ -114,7 +116,7 @@ wack_double (register double u, register { register double l = u, r = v; l = add_double (l, r); - return l; + return l + r; } doublest @@ -122,7 +124,7 @@ wack_doublest (register doublest u, regi { register doublest l = u, r = v; l = add_doublest (l, r); - return l; + return l + r; } /* */ @@ -253,7 +255,7 @@ int main () { /* These calls are for current frame test. */ - wack_char (-1, -2); + wack_charest (-1, -2); wack_short (-1, -2); wack_int (-1, -2); wack_long (-1, -2); @@ -263,7 +265,7 @@ main () wack_doublest (-1, -2); /* These calls are for up frame. */ - wack_char (-1, -2); + wack_charest (-1, -2); wack_short (-1, -2); wack_int (-1, -2); wack_long (-1, -2); Index: gdb/testsuite/gdb.base/store.exp =================================================================== --- gdb.orig/testsuite/gdb.base/store.exp 2003-07-01 17:56:38.000000000 -0400 +++ gdb/testsuite/gdb.base/store.exp 2003-07-03 09:48:05.000000000 -0400 @@ -63,11 +63,11 @@ proc check_set { t l r new add } { gdb_test "print r" " = ${r}" "print old r - ${t}" gdb_test "set variable l = 4" gdb_test "print l" " = ${new}" "print new l - ${t}" - gdb_test "next" "return l;" + gdb_test "next" "return l \\+ r;" gdb_test "print l" " = ${add}" "print add - ${t}" } -check_set "char" "-1 .*" "-2 .*" "4 ..004." "2 ..002." +check_set "charest" "-1 .*" "-2 .*" "4 ..004." "2 ..002." check_set "short" "-1" "-2" "4" "2" check_set "int" "-1" "-2" "4" "2" check_set "long" "-1" "-2" "4" "2" @@ -89,7 +89,7 @@ proc up_set { t l r new } { gdb_test "print l" " = ${new}" "up print new l - ${t}" } -up_set "char" "-1 .*" "-2 .*" "4 ..004." +up_set "charest" "-1 .*" "-2 .*" "4 ..004." up_set "short" "-1" "-2" "4" up_set "int" "-1" "-2" "4" up_set "long" "-1" "-2" "4"