From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6564 invoked by alias); 27 Jun 2003 17:28:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6526 invoked from network); 27 Jun 2003 17:28:34 -0000 Received: from unknown (HELO mailhost.intrinsity.com) (208.246.32.130) by sources.redhat.com with SMTP; 27 Jun 2003 17:28:34 -0000 Received: from victoria.intrinsity.com (victoria.eng.intrinsity.com [192.168.1.29]) by mailhost.intrinsity.com (Postfix) with ESMTP id 018443F3B3 for ; Fri, 27 Jun 2003 12:28:33 -0500 (CDT) Received: from bletchley.vert.intrinsity.com (bletchley.vert.intrinsity.com [192.168.3.33]) by victoria.intrinsity.com (Postfix) with ESMTP id CB24E4586C; Fri, 27 Jun 2003 12:28:33 -0500 (CDT) Received: by bletchley.vert.intrinsity.com (Postfix, from userid 621) id 430618B5FD; Fri, 27 Jun 2003 17:28:33 +0000 (UTC) Subject: [RFA] Eliminate hard coded constant num_regs in mips_gdbarch_init To: gdb-patches@sources.redhat.com Date: Fri, 27 Jun 2003 17:28:00 -0000 Cc: fnf@intrinsity.com (Fred Fish) Reply-To: fnf@intrinsity.com (Fred Fish) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20030627172833.430618B5FD@bletchley.vert.intrinsity.com> From: fnf@intrinsity.com (Fred Fish) X-SW-Source: 2003-06/txt/msg00821.txt.bz2 It seems wrong to hard code the number of registers in mips_gdbarch_init. Here is one way to fix it, for the case "num_regs=90", and possibly for the "num_regs=71" case also. However using sizeof(mips_generic_reg_names) is somewhat of a misleading way to find the number of strings in MIPS_REGISTER_NAMES and I'm not too thrilled about using a hard coded 32 instead of something like "sizeof(mips_gpr_names)/sizeof(char*)". -Fred 2003-06-25 Fred Fish * mips-tdep.c (mips_gdbarch_init): Set num_regs to be the number of base registers (32) plus the number of machine dependent register names, which should equal the number of machine dependent registers. Index: mips-tdep.c =================================================================== RCS file: /mips/newtools/fsf/gdb/gdb/mips-tdep.c,v retrieving revision 1.21 retrieving revision 1.22 diff -c -p -r1.21 -r1.22 *** mips-tdep.c 2003/06/23 14:31:26 1.21 --- mips-tdep.c 2003/06/26 02:36:53 1.22 *************** mips_gdbarch_init (struct gdbarch_info i *** 5908,5914 **** if (info.osabi == GDB_OSABI_IRIX) num_regs = 71; else ! num_regs = 90; set_gdbarch_num_regs (gdbarch, num_regs); set_gdbarch_num_pseudo_regs (gdbarch, num_regs); --- 5908,5914 ---- if (info.osabi == GDB_OSABI_IRIX) num_regs = 71; else ! num_regs = 32 + sizeof(mips_generic_reg_names)/sizeof(char *); set_gdbarch_num_regs (gdbarch, num_regs); set_gdbarch_num_pseudo_regs (gdbarch, num_regs);