From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17037 invoked by alias); 19 Jun 2003 13:18:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17017 invoked from network); 19 Jun 2003 13:18:50 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 19 Jun 2003 13:18:50 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19SzK5-0001NR-00; Thu, 19 Jun 2003 08:19:29 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19SzJD-0006Ad-00; Thu, 19 Jun 2003 09:18:35 -0400 Date: Thu, 19 Jun 2003 13:18:00 -0000 From: Daniel Jacobowitz To: Kris Warkentin Cc: "Gdb-Patches@Sources.Redhat.Com" Subject: Re: [Patch] arch recognition fix for osabi.c Message-ID: <20030619131834.GA23704@nevyn.them.org> Mail-Followup-To: Kris Warkentin , "Gdb-Patches@Sources.Redhat.Com" References: <08c201c334e6$ccb8c750$0202040a@catdog> <20030617155147.GA25280@nevyn.them.org> <08d801c334ea$23fd99c0$0202040a@catdog> <047501c3365d$f809dc00$0202040a@catdog> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <047501c3365d$f809dc00$0202040a@catdog> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00626.txt.bz2 I'm still not convinced. I'm keeping your last message around until I have a chance to examine what the compatible functions are really doing. On Thu, Jun 19, 2003 at 08:26:11AM -0400, Kris Warkentin wrote: > Daniel, did you have any further spare brain cycles to consider my argument? > > cheers, > > Kris > > > > > Changelog: > > > > * osabi.c (gdbarch_init_osabi): Just check arch for compatability > > rather > > > > identicality. > > > > > > Your mailer is eating indentation again... > > > > Yeah. It's fine in the editor - it's the cut and paste to Outlook that > > buggers it. > > > > > This half I'm not convinced by. From our previous exchange I don't > > > think you've fully justified it. Not approved without more discussion. > > > > Okay. Let's use mips as an example. The 'compatible' check returns true > if > > they have the same arch (ie. bfd_arch_mips). There will be many different > > values for the arch_info pointer, all with bfd_arch_mips and various other > > pieces of info such as which machine type (10k, 4300, etc.) of mips it is. > > The handler was registered for bfd_arch_mips with no other information. > In > > the absence of the ABILITY to do anything smarter, we have to assume that > if > > the handler is for bfd_arch_mips, it should be run. > > > > As it stands, if the bfd reads a file and says 'this is a tx3900' or some > > such, the pointers won't be the same and my backend init_abi won't be run > > even though I want it to run for all mips targets. > > > > > > (generic_elf_osabi_sniff_abi_tag_sections): Add check for QNX > > Neutrino > > > > binaries. > > > > > > This bit looks fine, except for two things: you've missed the coding > > > standards by four space characters (before left parens), and your > > > "safety first" check overruns the buffer (missing +1 in the alloca). > > > > Doh! Not very safe was it? Sorry about that. Fixed. > > > > cheers, > > > > Kris > > > > > > > > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer