From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11411 invoked by alias); 18 Jun 2003 23:27:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11392 invoked from network); 18 Jun 2003 23:27:22 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 18 Jun 2003 23:27:22 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19SmLb-0000B4-00; Wed, 18 Jun 2003 18:28:11 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19SmKl-0000I9-00; Wed, 18 Jun 2003 19:27:19 -0400 Date: Wed, 18 Jun 2003 23:27:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: "J. Johnston" , gdb-patches@sources.redhat.com Subject: Re: RFA: gdb linux nptl patch 1 Message-ID: <20030618232718.GA1104@nevyn.them.org> Mail-Followup-To: Michael Snyder , "J. Johnston" , gdb-patches@sources.redhat.com References: <3E84E672.3050506@redhat.com> <3EF0F0DF.2030802@redhat.com> <20030618231149.GA469@nevyn.them.org> <3EF0F456.2040504@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EF0F456.2040504@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00608.txt.bz2 On Wed, Jun 18, 2003 at 04:23:02PM -0700, Michael Snyder wrote: > Daniel Jacobowitz wrote: > >On Wed, Jun 18, 2003 at 04:08:15PM -0700, Michael Snyder wrote: > > > >>J. Johnston wrote: > >>[...] > >> > >>>This patch proposes adding a secondary list of thread_info structs that > >>>keeps > >>>track of the lwps. This list is kept distinct from the regular thread > >>>list. > >>>Since manipulating either list involves common operations, some base > >>>operations > >>>are added for generic thread_info list manipulation. The lin-lwp.c > >>>layer is > >>>changed to add and delete lwp thread_info structs to the lwp list when > >>>lwps > >>>are added or deleted. The linux-proc.c code is changed to iterate > >>>through the > >>>lwp thread_info list rather than the thread list when creating the > >>>pr_status > >>>notes. > >> > >>Jeff, did you realize that lin-lwp.c already maintains a list of lwps? > >>It even exports an iterator function. I think this list you're adding > >>may be redundant. > > > > > >It exports an iterator, but you can't usefully declare the iterator's > >callback anywhere, since struct lwp_info is local to lin-lwp.c... > > > > No biggie, I'll just export that into a new file lin-lwp.h > (along with a prototype of the iterator). Sounds good. I've been using nm-linux.h for this sort of thing; but how about... um... maybe linux-nat.h? That's a little more generic. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer