From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13580 invoked by alias); 18 Jun 2003 23:11:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13537 invoked from network); 18 Jun 2003 23:11:58 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 18 Jun 2003 23:11:58 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19Sm6h-00009Z-00; Wed, 18 Jun 2003 18:12:47 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19Sm5l-00007z-00; Wed, 18 Jun 2003 19:11:49 -0400 Date: Wed, 18 Jun 2003 23:11:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: "J. Johnston" , gdb-patches@sources.redhat.com Subject: Re: RFA: gdb linux nptl patch 1 Message-ID: <20030618231149.GA469@nevyn.them.org> Mail-Followup-To: Michael Snyder , "J. Johnston" , gdb-patches@sources.redhat.com References: <3E84E672.3050506@redhat.com> <3EF0F0DF.2030802@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EF0F0DF.2030802@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00605.txt.bz2 On Wed, Jun 18, 2003 at 04:08:15PM -0700, Michael Snyder wrote: > J. Johnston wrote: > [...] > >This patch proposes adding a secondary list of thread_info structs that > >keeps > >track of the lwps. This list is kept distinct from the regular thread > >list. > >Since manipulating either list involves common operations, some base > >operations > >are added for generic thread_info list manipulation. The lin-lwp.c > >layer is > >changed to add and delete lwp thread_info structs to the lwp list when lwps > >are added or deleted. The linux-proc.c code is changed to iterate > >through the > >lwp thread_info list rather than the thread list when creating the > >pr_status > >notes. > > Jeff, did you realize that lin-lwp.c already maintains a list of lwps? > It even exports an iterator function. I think this list you're adding > may be redundant. It exports an iterator, but you can't usefully declare the iterator's callback anywhere, since struct lwp_info is local to lin-lwp.c... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer