From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18871 invoked by alias); 13 Jun 2003 01:48:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18840 invoked from network); 13 Jun 2003 01:48:52 -0000 Received: from unknown (HELO caip.rutgers.edu) (128.6.236.10) by sources.redhat.com with SMTP; 13 Jun 2003 01:48:52 -0000 Received: (from ghazi@localhost) by caip.rutgers.edu (8.9.3/8.9.3) id VAA12952; Thu, 12 Jun 2003 21:48:42 -0400 (EDT) Date: Fri, 13 Jun 2003 01:48:00 -0000 From: "Kaveh R. Ghazi" Message-Id: <200306130148.VAA12952@caip.rutgers.edu> To: brobecker@gnat.com Subject: Re: Re: [RFA/PING] Fix libiberty compilation failure on systems running AiX 4.x Cc: dj@redhat.com, gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com References: <20030601070114.GJ919@gnat.com> <20030613000346.GB947@gnat.com> X-SW-Source: 2003-06/txt/msg00448.txt.bz2 > It would be nice to have this looked at in the near future because it > currently fails to build on AiX 4.x, and the GDB 6 release is getting > nearer. I'd rather have this problem be fixed before we cut the GDB6 > branch. > Thank you, Sorry, this patch is wrong. It deactivates the code on all aix4*, whereas the code is correct on 4.3.3 and later. It is only on 4.3.2 and prior that this code breaks. Rather than hardwire aix version numbers, the correct fix is to use an autoconf feature test. See this bug report: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10974 I (just a few days ago) installed this exact fix in gcc's libiberty. What needs to happen is for this code to be copied into gdb and binutils. I don't have access to these repos, which is why I copied DJ on the install email. I should have explicitly mentioned that I needed him to propagate it, sorry for not saying so. DJ would you please sync this patch with the other libiberty repos? http://gcc.gnu.org/ml/gcc-patches/2003-06/msg00767.html Thanks, --Kaveh -- Kaveh R. Ghazi ghazi@caip.rutgers.edu