From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23147 invoked by alias); 12 Jun 2003 23:18:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23044 invoked from network); 12 Jun 2003 23:18:01 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 12 Jun 2003 23:18:01 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19QbLB-0000Zf-00; Thu, 12 Jun 2003 18:18:45 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19QbJv-0005Ao-00; Thu, 12 Jun 2003 19:17:27 -0400 Date: Thu, 12 Jun 2003 23:18:00 -0000 From: Daniel Jacobowitz To: David Carlton Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] always use demangled name to set scope Message-ID: <20030612231727.GA19870@nevyn.them.org> Mail-Followup-To: David Carlton , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00438.txt.bz2 On Thu, Jun 12, 2003 at 03:26:34PM -0700, David Carlton wrote: > As per recent discussions, it seems likely that the variable > 'processing_current_namespace' isn't always valid: if a function is > declared in a namespace but defined outside the body of that > namespace, then probably sometimes dwarf2read.c won't notice that, > because of a DW_AT_specification tag, the current namespace is > different from what is given by the immediate hierarchical structure. > > I'm trying to sort this out on my branch, but I think I'd prefer a > less intrusive fix on the mainline, since we're about to branch for > GDB 6.0. Fortunately, the mainline currently only uses that variable > in once place, namely cp_set_block_scope. And, in that situation, it > has the fallback strategy of looking at the demangled name. > > So this patch tells GDB to just always use that fallback strategy for > now. It should work fine in the short term; we can get this all > straightened out fully for 6.1, as part of merging in the rest of my > branch (in particular nested types support). > > Tested on GCC 3.2, DWARF 2, i686-pc-linux-gnu; no new regressions. I > also ran gdb.c++/namespace.exp with a version of GCC patched to > generated DW_TAG_namespace entries, and I didn't get any regressions > there, either. OK to commit? Yes. By 6.1 I want to rip out all uses of the demangled name along the DWARF-2 code path though. If I can find the time... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer