From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28478 invoked by alias); 12 Jun 2003 17:01:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28466 invoked from network); 12 Jun 2003 17:01:48 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 12 Jun 2003 17:01:48 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19QVT3-0008Dj-00; Thu, 12 Jun 2003 12:02:29 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19QVSG-0004Ot-00; Thu, 12 Jun 2003 13:01:40 -0400 Date: Thu, 12 Jun 2003 17:01:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: David Carlton , gdb-patches@sources.redhat.com, ezannoni@redhat.com, jimb@redhat.com Subject: Re: [commit] remove DEPRECATED_SYMBOL_NAME uses from symtab.c Message-ID: <20030612170140.GA16891@nevyn.them.org> Mail-Followup-To: Andrew Cagney , David Carlton , gdb-patches@sources.redhat.com, ezannoni@redhat.com, jimb@redhat.com References: <3EE8B108.7020306@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EE8B108.7020306@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00421.txt.bz2 On Thu, Jun 12, 2003 at 12:57:44PM -0400, Andrew Cagney wrote: > Does this: > > > #define COMPLETION_LIST_ADD_SYMBOL(symbol, sym_text, len, text, word) \ > >- do { \ > >- if (SYMBOL_DEMANGLED_NAME (symbol) != NULL) \ > >- /* Put only the mangled name on the list. */ \ > >- /* Advantage: "b foo" completes to "b foo(int, int)" */ \ > >- /* Disadvantage: "b foo__i" doesn't complete. */ \ > > completion_list_add_name \ > >- (SYMBOL_DEMANGLED_NAME (symbol), (sym_text), (len), (text), (word)); > >\ > >- else \ > >- completion_list_add_name \ > >- (DEPRECATED_SYMBOL_NAME (symbol), (sym_text), (len), (text), > >(word)); \ > >- } while (0) > >+ (SYMBOL_NATURAL_NAME (symbol), (sym_text), (len), (text), (word)) > > mean that COMPLETION_LIST_ADD_SYMBOL is also dead? (I have trouble > reading unified diffs :-) I guess so - it's still there, but it looks to me like it's a transparent function call now. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer