From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8613 invoked by alias); 10 Jun 2003 01:54:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8546 invoked from network); 10 Jun 2003 01:54:40 -0000 Received: from unknown (HELO ms-smtp-02.nyroc.rr.com) (24.92.226.49) by sources.redhat.com with SMTP; 10 Jun 2003 01:54:40 -0000 Received: from doctormoo (syr-24-24-16-157.twcny.rr.com [24.24.16.157]) by ms-smtp-02.nyroc.rr.com (8.12.5/8.12.2) with ESMTP id h5A1sdpn005160; Mon, 9 Jun 2003 21:54:39 -0400 (EDT) Received: from neroden by doctormoo with local (Exim 3.36 #1 (Debian)) id 19PYLG-0004u6-00; Mon, 09 Jun 2003 21:54:30 -0400 Date: Tue, 10 Jun 2003 01:54:00 -0000 To: dj@redhat.com Cc: gcc-patches@gcc.gnu.org, binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [toplevel patch] Remove bogus conditional Message-ID: <20030610015429.GA11332@doctormoo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.4i From: Nathanael Nerode X-SW-Source: 2003-06/txt/msg00319.txt.bz2 >> Nobody noticed. :-) > >Unfortunately, that doesn't mean a lot. > >> Tested on i686-pc-linux-gnu. > >Could you test the case this is designed for, i.e., cross-building a >native? Here's the curious thing. The case this is designed for was unchanged by the typo. (The case where host_canonical != build_canonical. With the typo, host_canon*ci*al != build_canonical, so it still executes.) The case which was changed by the typo is the case where host_canonical=build_canonical (but due to the typo, host_canon*ci*al != build_canonical). In other words, the native and ordinary cross cases. Which I'm guessing are sufficiently tested, and which is why I'm surprised that nobody noticed. At the moment, I can't test a cross-built native properly 'cause I can't find any which ever worked quite right for me. :-( But that's the case where I never changed anything here! --Nathanael