From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2014 invoked by alias); 4 Jun 2003 06:05:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1973 invoked from network); 4 Jun 2003 06:05:25 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 4 Jun 2003 06:05:25 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 6D8CAD2DAF; Tue, 3 Jun 2003 23:05:12 -0700 (PDT) Date: Wed, 04 Jun 2003 06:05:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c Message-ID: <20030604060512.GW919@gnat.com> References: <20030604002702.GP919@gnat.com> <3EDD5DAA.1060300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EDD5DAA.1060300@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-06/txt/msg00167.txt.bz2 > >2003-06-03 J. Brobecker > > > > * alpha-osf1-tdep.c (alpha_osf1_skip_sigtramp_frame): Replace > > references to struct frame_info fields by calls to the equivalent > > accessors. Necessary now that frame_info is opaque. > > (alpha_osf1_pc_in_sigtramp): Likewise. > > > >Looks ok? > > Yes. If you're feeling game you could use get_frame_memory, but > either way. Andrew, please forgive for not having followed the discussions about the new frame architecture too closely (I did go and read the messages you recently pointed out to Daniel, though!). You are saying either way; however, my current understanding is that get_frame_memory is not currently any different from the above, but is still a better approach in the long run if we eventually want to be multi-everything. Is it correct? I am not sure if it is really worth fixing this sort of thing now, or worry about it later... You know the grand plan, so your call. -- Joel