Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: [commit] Re: Last build failure in alpha-osf1-tdep.c (I promise :)
Date: Wed, 04 Jun 2003 05:35:00 -0000	[thread overview]
Message-ID: <20030604053529.GT919@gnat.com> (raw)
In-Reply-To: <3EDD62F3.3060306@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

> Check alpha-linux-tdep.c, you'll want to steal the call:
>
>   /* Hook into the MDEBUG frame unwinder.  */
>   alpha_mdebug_init_abi (info, gdbarch);

A separate patch will be posted real-soon-now...

> adding it to alpha-osf1-tdep.c.  That will enable mdebug.
> 
> >        * alpha-osf1-tdep.c (alpha_osf1_init_abi): Do not set
> >        skip_sigtramp_frame in tdep structure, field no longer exists.
> 
> Check this in.  In fact, consider a patch to delete all occurances of 
> that function across alpha*tdep.c pre-approved.

Here is what I committed:

2003-06-03  J. Brobecker  <brobecker@gnat.com>

        * alpha-osf1-tdep.c (alpha_osf1_skip_sigtramp_frame): Delete.
        (alpha_osf1_init_abi): Do not set skip_sigtramp_frame in tdep
        structure, field no longer exists.

There is still the alphanbsd-tdep.c file. I will take care of this one
momentarily.

Thanks for the hand,
-- 
Joel

[-- Attachment #2: sigtramp.diff --]
[-- Type: text/plain, Size: 1263 bytes --]

Index: alpha-osf1-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-osf1-tdep.c,v
retrieving revision 1.12
diff -c -3 -p -r1.12 alpha-osf1-tdep.c
*** alpha-osf1-tdep.c	3 Jun 2003 23:49:32 -0000	1.12
--- alpha-osf1-tdep.c	4 Jun 2003 05:06:58 -0000
***************
*** 28,46 ****
  
  #include "alpha-tdep.h"
  
- /* Under OSF/1, the __sigtramp routine is frameless and has a frame
-    size of zero, but we are able to backtrace through it.  */
- static CORE_ADDR
- alpha_osf1_skip_sigtramp_frame (struct frame_info *frame, CORE_ADDR pc)
- {
-   char *name;
- 
-   find_pc_partial_function (pc, &name, (CORE_ADDR *) NULL, (CORE_ADDR *) NULL);
-   if (PC_IN_SIGTRAMP (pc, name))
-     return frame->frame;
-   return 0;
- }
- 
  static int
  alpha_osf1_pc_in_sigtramp (CORE_ADDR pc, char *func_name)
  {
--- 28,33 ----
*************** alpha_osf1_init_abi (struct gdbarch_info
*** 95,101 ****
       argument handling and bp_call_dummy takes care of stopping the dummy.  */
    set_gdbarch_call_dummy_address (gdbarch, alpha_call_dummy_address);
  
-   tdep->skip_sigtramp_frame = alpha_osf1_skip_sigtramp_frame;
    tdep->sigcontext_addr = alpha_osf1_sigcontext_addr;
  
    tdep->jb_pc = 2;
--- 89,94 ----

      parent reply	other threads:[~2003-06-04  5:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-04  0:45 Joel Brobecker
2003-06-04  3:09 ` Andrew Cagney
2003-06-04  5:24   ` Richard Henderson
2003-06-04  5:35   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030604053529.GT919@gnat.com \
    --to=brobecker@gnat.com \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox