From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23608 invoked by alias); 2 Jun 2003 20:40:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23570 invoked from network); 2 Jun 2003 20:40:15 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 2 Jun 2003 20:40:15 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19Mw6t-0006xc-00; Mon, 02 Jun 2003 15:40:51 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19Mw6D-0004H9-00; Mon, 02 Jun 2003 16:40:09 -0400 Date: Mon, 02 Jun 2003 20:40:00 -0000 From: Daniel Jacobowitz To: Richard Henderson Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] cleanup alpha core read/write registers Message-ID: <20030602204008.GA16342@nevyn.them.org> Mail-Followup-To: Richard Henderson , gdb-patches@sources.redhat.com References: <20030602181937.GA15118@twiddle.net> <20030602202949.GA25944@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030602202949.GA25944@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00088.txt.bz2 On Mon, Jun 02, 2003 at 01:29:49PM -0700, Richard Henderson wrote: > On Mon, Jun 02, 2003 at 11:19:37AM -0700, Richard Henderson wrote: > > RFA because I'm touching systems I can't test. > > > > As far as alpha-nat is concerned, this gets rid of the use > > of the deprecated register array. Indeed, there are no > > longer *any* instances of "deprecated" in the alpha port. > > > > As far as Linux is concerned, this fixes the gcore test > > because we now properly dump the FPCR and UNIQUE registers. > > > > As far as the BSD's are concerned, this should be a no-op, > > just avoiding some amount of code duplication. > > > > Ok? > > Gah. This is the patch I meant to send. I don't have anywhere to test it either, but it looks good. This touches some code which would be triggered on Tru64, right? If so and you're particularly nervous about it, ask Joel Brobecker to test it. Otherwise I think it's OK to check in. > > > r~ > > > > * alpha-tdep.c (alpha_supply_int_regs, alpha_fill_int_regs): New. > (alpha_supply_fp_regs, alpha_fill_fp_regs): New. > * alpha-tdep.h: Declare them. > > * alpha-nat.c (fetch_osf_core_registers): Constify core_reg_mapping. > Remove zerobuf. Don't error on UNIQUE. > (fetch_elf_core_registers): Use alpha_supply_{int,fp}_regs. > (ALPHA_REGSET_UNIQUE): Provide default. > (supply_gregset): Use alpha_supply_int_regs. > (fill_gregset): Use alpha_fill_int_regs. > (supply_fpregset): Use alpha_supply_fp_regs. > (fill_fpregset): Use alpha_fill_fp_regs. > * alphabsd-tdep.c (NUM_GREGS, NUM_FPREGS): Remove. > (alphabsd_supply_reg): Use alpha_supply_int_regs. > (alphabsd_fill_reg): Use alpha_fill_int_regs. > (alphabsd_supply_fpreg): Use alpha_supply_fp_regs. > (alphabsd_fill_fpreg): Use alpha_fill_fp_regs. > * config/alpha/nm-linux.h (ALPHA_REGSET_UNIQUE): New. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer