Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: gdb-patches@sources.redhat.com
Subject: [RFA] fix calling conventions wrt 32-bit values
Date: Mon, 02 Jun 2003 05:53:00 -0000	[thread overview]
Message-ID: <20030602055343.GA7598@twiddle.net> (raw)

Ok?


r~


	* alpha-tdep.c (alpha_push_dummy_call): Handle ABI mandated 
	sign-extension of 32-bit values.
	(alpha_store_return_value): Similarly.


--- alpha-tdep.c.5	2003-06-01 22:34:01.000000000 -0700
+++ alpha-tdep.c	2003-06-01 22:42:32.000000000 -0700
@@ -276,9 +276,16 @@ alpha_push_dummy_call (struct gdbarch *g
 	case TYPE_CODE_CHAR:
 	case TYPE_CODE_RANGE:
 	case TYPE_CODE_ENUM:
-	  if (TYPE_LENGTH (arg_type) < TYPE_LENGTH (builtin_type_long))
+	  if (TYPE_LENGTH (arg_type) == 4)
 	    {
-	      arg_type = builtin_type_long;
+	      /* 32-bit values must be sign-extended to 64 bits
+		 even if the base data type is unsigned.  */
+	      arg_type = builtin_type_int32;
+	      arg = value_cast (arg_type, arg);
+	    }
+	  if (TYPE_LENGTH (arg_type) < ALPHA_REGISTER_SIZE)
+	    {
+	      arg_type = builtin_type_int64;
 	      arg = value_cast (arg_type, arg);
 	    }
 	  break;
@@ -541,6 +548,10 @@ alpha_store_return_value (struct type *v
 
     default:
       /* Assume everything else degenerates to an integer.  */
+      /* 32-bit values must be sign-extended to 64 bits
+	 even if the base data type is unsigned.  */
+      if (length == 4)
+	valtype = builtin_type_int32;
       l = unpack_long (valtype, valbuf);
       regcache_cooked_write_unsigned (regcache, ALPHA_V0_REGNUM, l);
       break;


             reply	other threads:[~2003-06-02  5:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-02  5:53 Richard Henderson [this message]
2003-06-02 13:43 ` Elena Zannoni
2003-06-02 16:00   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030602055343.GA7598@twiddle.net \
    --to=rth@twiddle.net \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox