Re: [RFA] update alpha return value hooks to regcache

Andrew Cagney
2003-06-02T18:40:11Z

> Richard Henderson <rth@twiddle.net> writes:
>
>
>> Ok?
>>
>> r~
>>
>> * alpha-tdep.c (alpha_extract_return_value): Convert to regcache.
>> (alpha_extract_struct_value_address): Likewise.
>> (alpha_store_return_value): Likewise.
>> (alpha_store_struct_return): Remove.
>> (alpha_gdbarch_init): Update hook registration to match.
>>
>
>
> Ah, this one's got a flaw. Using abort() isn't allowed in GDB.
> Instead use internal_error() which gives the user the option of
> continuing at his/her own risk. You could also use gdb_assert()
> (which calls internal_error()).
>
> With that change, this is approved.

BTW, also:

> ! case 4:
> ! alpha_convert_flt_dbl (raw_buffer, valbuf);
> ! valbuf = raw_buffer;
> ! /* FALLTHRU */
> !
> ! case 8:
> ! regcache_cooked_write (regcache, ALPHA_FP0_REGNUM, valbuf);
> ! break;
> !
> ! default:
> ! abort ();

please avoid the fallthrough.

Andrew