Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: gdb-patches@sources.redhat.com
Subject: [RFA] skip fde augmentation
Date: Sun, 01 Jun 2003 06:07:00 -0000	[thread overview]
Message-ID: <20030601060757.GA2224@twiddle.net> (raw)

Found by inspection.

I assume that the bulk of the dwarf2 testing has been done
on C code.  C++ code that handles exceptions would wind up
executing bogus CFA opcodes.

Ok?


r~



	* dwarf2-frame.c (struct dwarf2_cie): Add saw_z_augmentation.
	(decode_frame_entry): Set it.  Skip FDE augmentation.

--- dwarf2-frame.c.orig	2003-05-31 22:23:54.000000000 -0700
+++ dwarf2-frame.c	2003-05-31 22:30:21.000000000 -0700
@@ -65,6 +65,9 @@ struct dwarf2_cie
   /* Encoding of addresses.  */
   unsigned char encoding;
 
+  /* True if a 'z' augmentation existed.  */
+  unsigned char saw_z_augmentation;
+
   struct dwarf2_cie *next;
 };
 
@@ -1111,7 +1114,8 @@ decode_frame_entry (struct comp_unit *un
       cie->return_address_register = read_1_byte (unit->abfd, buf);
       buf += 1;
 
-      if (*augmentation == 'z')
+      cie->saw_z_augmentation = (*augmentation == 'z');
+      if (cie->saw_z_augmentation)
 	{
 	  ULONGEST length;
 
@@ -1200,6 +1204,18 @@ decode_frame_entry (struct comp_unit *un
 	read_encoded_value (unit, fde->cie->encoding & 0x0f, buf, &bytes_read);
       buf += bytes_read;
 
+      /* A 'z' augmentation in the CIE implies the presence of an
+	 augmentation field in the FDE as well.  The only thing known
+	 to be in here at present is the LSDA entry for EH.  So we
+	 can skip the whole thing.  */
+      if (fde->cie->saw_z_augmentation)
+	{
+	  ULONGEST length;
+
+	  length = read_unsigned_leb128 (unit->abfd, buf, &bytes_read);
+	  buf += bytes_read + length;
+	}
+
       fde->instructions = buf;
       fde->end = end;
 


             reply	other threads:[~2003-06-01  6:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-01  6:07 Richard Henderson [this message]
2003-06-01  9:26 ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030601060757.GA2224@twiddle.net \
    --to=rth@twiddle.net \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox