From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12484 invoked by alias); 26 May 2003 22:03:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12476 invoked from network); 26 May 2003 22:03:08 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 26 May 2003 22:03:08 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19KQ3Z-0005yR-00; Mon, 26 May 2003 17:03:02 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19KQ2x-0006ro-00; Mon, 26 May 2003 18:02:23 -0400 Date: Mon, 26 May 2003 22:03:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] HPUX: Remove (non-useful?) definition of PREPARE_TO_PROCEED Message-ID: <20030526220223.GA32360@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20030526211558.GH11123@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030526211558.GH11123@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-05/txt/msg00491.txt.bz2 On Mon, May 26, 2003 at 02:15:58PM -0700, Joel Brobecker wrote: > Re: http://sources.redhat.com/ml/gdb-patches/2003-05/msg00487.html > > Based on Daniel's hunch, I made the following change, and it tested ok > on our machine. I get the same set of failures for the threads tests: > > FAIL: gdb.threads/print-threads.exp: Running threads (fast) (timeout) > ERROR: Delete all breakpoints in delete_breakpoints (timeout) > FAIL: gdb.threads/print-threads.exp: break thread_function (2) (timeout) > FAIL: gdb.threads/print-threads.exp: set var slow = 1 (timeout) > FAIL: gdb.threads/print-threads.exp: Running threads (slow) (timeout) > ERROR: Delete all breakpoints in delete_breakpoints (timeout) > FAIL: gdb.threads/print-threads.exp: break thread_function (3) (timeout) > FAIL: gdb.threads/print-threads.exp: set var slow = 1 (2) (timeout) > FAIL: gdb.threads/print-threads.exp: break kill (timeout) > FAIL: gdb.threads/print-threads.exp: Running threads (slow with kill breakpoint) (timeout) > > In all honesty, I know very little about this, so it was just a > have-a-look kind of test. But based on the fact that this test confirms > Daniel's initial suspicion, I would think that this patch is safe to > apply. Since it will help doing some cleanup.... It won't actually show up in the testsuite. I'm trying and trying to remember which bug report I was working on when I developed the prepare-to-proceed patch in the first place. Also, removing the definition means that you'll use default_prepare_to_proceed (which is essentially useless) instead of the generic_prepare_to_proceed which I'm proposing we use instead. > 2003-05-26 J. Brobecker > > * config/pa/nm-hppah.h (PREPARE_TO_PROCEED): Remove, no longer needed. > * hppa-tdep.c (hppa_prepare_to_proceed): Likewise. > > Shall I commit this patch? > > Thanks, (and Thanks to Daniel for the suggestion) Would you do me the great favor of retesting with changing PREPARE_TO_PROCEED to use generic_prepare_to_proceed instead of hppa_prepare_to_proceed? And if no one objects in a few days, commit that. Then the rest falls out, since you will have removed one of the two remaining specializations of this method. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer