Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: [branch patch] core files as symfiles
Date: Thu, 15 May 2003 22:19:00 -0000	[thread overview]
Message-ID: <200305152219.h4FMJc812037@magilla.sf.frob.com> (raw)
In-Reply-To: Elena Zannoni's message of  Thursday, 15 May 2003 18:05:48 -0400 <16068.3900.457800.96561@localhost.redhat.com>

> Did we settle on this being the solution though? I think the
> /proc/PID/auxv approach is a bit cleaner. 

We're talking about core files, so what you mean is an NT_AUXV note that
would give the same information that /proc/PID/auxv would give for a live
process.  It remains to see whether the auxv approach will be accepted in
the kernel.  

If that is done, then the corelow.c patch will be superfluous.  I would
like feedback on the implementation issue of this patch regardless.  That
is, if anyone sees any potential problems with adding the core bfd as a
symfile (AFAIK it's a no-op to all cases but the new vsyscall issues), or
with my specific code changes.  Then I can address any nits, and verify
that it is a safe change for gdb generically speaking.  It is useful to
know ASAP that this very simple change works acceptably, even if it turns
out not to be necessary in the end.

Using the core file's phdrs (which is what happens implicitly using this
patch) has the benefit that it works now, i.e. with kernel support already
merged into Linux 2.5, and with gdb code I have already finished enough to
be in submittable form.  If the generic auxv exporting support is not
accepted in the kernel, then it is quite likely that some other way to know
the vsyscall DSO address in a live process (e.g. via /proc/PID/maps) *will*
be accepted, but no other core dump changes will go in and the existing
phdrs will be the only method for the core dump case.


Thanks,
Roland


  reply	other threads:[~2003-05-15 22:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-12  9:47 [branch patch] dwarf-frame.c support for .eh_frame_hdr Roland McGrath
2003-05-13  3:27 ` Elena Zannoni
2003-05-13  3:42   ` Roland McGrath
2003-05-15 21:49 ` Mark Kettenis
2003-05-15 22:00   ` Elena Zannoni
2003-05-15 22:19     ` Roland McGrath [this message]
2003-05-15 23:58       ` [branch patch] core files as symfiles Andrew Cagney
2003-05-15 22:06   ` [branch patch] dwarf-frame.c support for .eh_frame_hdr Roland McGrath
2003-05-13  2:59 [branch patch] core files as symfiles Roland McGrath
2003-05-15 21:58 ` Mark Kettenis
2003-05-15 23:29   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200305152219.h4FMJc812037@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox