From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12833 invoked by alias); 15 May 2003 21:49:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12757 invoked from network); 15 May 2003 21:49:24 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 15 May 2003 21:49:24 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id h4FLnGZN000385; Thu, 15 May 2003 23:49:16 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id h4FLnGHD000474; Thu, 15 May 2003 23:49:16 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id h4FLnGHK000471; Thu, 15 May 2003 23:49:16 +0200 (CEST) Date: Thu, 15 May 2003 21:49:00 -0000 Message-Id: <200305152149.h4FLnGHK000471@elgar.kettenis.dyndns.org> From: Mark Kettenis To: roland@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <200305120946.h4C9ksj17912@magilla.sf.frob.com> (message from Roland McGrath on Mon, 12 May 2003 02:46:54 -0700) Subject: Re: [branch patch] dwarf-frame.c support for .eh_frame_hdr References: <200305120946.h4C9ksj17912@magilla.sf.frob.com> X-SW-Source: 2003-05/txt/msg00258.txt.bz2 Date: Mon, 12 May 2003 02:46:54 -0700 From: Roland McGrath 2003-05-12 Roland McGrath * dwarf2read.c (dwarf_eh_frame_hdr_offset, dwarf_eh_frame_hdr_size, dwarf_eh_frame_hdr_section): New variables. (dwarf2_locate_sections): Match a section whose name starts with "eh_frame_hdr", and set those. (dwarf2_has_info): Clear dwarf_eh_frame_hdr_offset here. * dwarf-frame.c (decode_eh_frame_hdr): New function. (dwarf2_build_frame_info): Call it when dwarf_eh_frame_hdr_offset is set but dwarf_eh_frame_offset is not. Having to build a "dummy" `struct comp_unit' probably indicates that I should change read_encoded_value()'s signature. Well, I'll worry about that later. The error messages in dwarf-frame.c should probably be harmonized before we check merge this into mailine. I wonder whether we should complaint() instead of error(). Is there a particular reason why you don't read in the .eh_frame_hdr section as a whole as the other parts of GDB's "symbol reader" do (and which I just blindly copied when I wrote the guts of dwarf-frame.c)? * symfile.c (symfile_bfd_open): Try bfd_check_format with bfd_core if bfd_object fails. I think a more elaborate comment on why core files might have "symbols" is appropriate. Mark