From: DJ Delorie <dj@redhat.com>
To: kelleycook@wideopenwest.com
Cc: binutils@sources.redhat.com, gcc-patches@sources.redhat.com,
gdb-patches@sources.redhat.com, cc@wideopenwest.com
Subject: Re: TOPLEVEL PATCH: accept more x86 variants
Date: Thu, 15 May 2003 00:20:00 -0000 [thread overview]
Message-ID: <200305150020.h4F0Kbm25552@greed.delorie.com> (raw)
In-Reply-To: <3ec295fd.195c.1804289383@wideopenwest.com> (message from Kelley Cook on Wed, 14 May 2003 14:16:13 -0500)
> ---=_webmail-1.dnv.wideopenwest.com3ec295fd
> Content-Type: application/octet-stream; name="toplevel_x86.diff"
> Content-Transfer-Encoding: base64
> Content-Disposition: attachment; filename="toplevel_x86.diff"
Note that, in general, it's preferable to explicitly list each
character, in case locales or encodings rearrange the order of
characters (like EBCDIC does). While it doesn't matter in this case,
it's probably better to avoid ranges so that people don't get the idea
that they're OK for all cases.
Your patch is acceptable as-is, but if you could take the time to
expand the ranges, that would be a little better for long-term
portability.
next prev parent reply other threads:[~2003-05-15 0:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 19:16 Kelley Cook
2003-05-15 0:20 ` DJ Delorie [this message]
2003-05-15 14:29 ` Kelley Cook
2003-05-15 14:45 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305150020.h4F0Kbm25552@greed.delorie.com \
--to=dj@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=cc@wideopenwest.com \
--cc=gcc-patches@sources.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kelleycook@wideopenwest.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox