From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14912 invoked by alias); 13 May 2003 03:42:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14786 invoked from network); 13 May 2003 03:42:49 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.163.213.212) by sources.redhat.com with SMTP; 13 May 2003 03:42:49 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 6909C354C; Mon, 12 May 2003 20:42:48 -0700 (PDT) Received: (from roland@localhost) by magilla.sf.frob.com (8.11.6/8.11.6) id h4D3gmR23808; Mon, 12 May 2003 20:42:48 -0700 Date: Tue, 13 May 2003 03:42:00 -0000 Message-Id: <200305130342.h4D3gmR23808@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Elena Zannoni Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [branch patch] dwarf-frame.c support for .eh_frame_hdr In-Reply-To: Elena Zannoni's message of Monday, 12 May 2003 23:32:39 -0400 <16064.26455.650498.812097@localhost.redhat.com> X-Antipastobozoticataclysm: Bariumenemanilow X-SW-Source: 2003-05/txt/msg00196.txt.bz2 > Is there a way to tell if there is a table? Sure, my code does check that (size_of_encoded_value returns 0 in that case). It's just that if there is no table, I don't think there is anything else useful to try. AFAIK it's not a practical concern. It's just something that struck me when I came across it. > I see that the symfile.c change is a good way to test the code, and to > verify that the stuff that ends up in the core file makes sense. This > new add-symbol-file command required to read the symbols info from the > core file is however a bit of a departure from the standard way core > files are treated in gdb. It also not entirely clear to a user that > it would be necessary to issue it. I never suggested that users do such a thing. I did it myself to test the dwarf-frame.c changes, and included the symfile.c patch so that other could demonstrate for themselves that the .eh_frame_hdr decoding in fact works. (If you catch up with your mailbox, you'll notice that today I posted the patch I wrote later last night to implicitly do it for all core files.) Thanks, Roland