From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH/i386newframe/RFC] DWARF CFI frame unwinder
Date: Mon, 05 May 2003 14:59:00 -0000 [thread overview]
Message-ID: <20030505145903.GA29766@nevyn.them.org> (raw)
In-Reply-To: <3EB67AC6.2050407@redhat.com>
On Mon, May 05, 2003 at 10:52:54AM -0400, Andrew Cagney wrote:
>
> >>>The frame's CFA is the basis for identifying the frame and locating
> >>>saved registers in the CFI. It is always present when you have CFI.
> >>>
> >>>DW_AT_frame_base is the basis for locating saved variables and locals.
> >>>It is generally present when you have DWARF-2 debug info.
> >
> >>
> >>You and I went through all this not too long ago. frame-base is for
> >>this high level thingie, frame-unwind is for the low level register
> >>information.
> >
> >
> >Then, as Mark said, it shouldn't be providing a frame base at all. The
> >CFA information is not the right frame base, and the use of
> >DW_AT_frame_base is exactly orthogonal to the use of CFI.
>
> Daniel, you and I went through all this not too long ago.
>
> Not providing a dwarf2 specific frame-base (returning DW_AT_frame_base)
> leads to ``info frame'' printing inconsistent information. It will
> report ``id.stack_addr'' as the frame's base and that is definitly not
> correct - it won't match the high level ``base'' that the user expects
> to match a disassembler.
>
> Again, this is why the high level frame-base is separate to the low
> level frame-unwind. It is possible to mix 'n' match.
>
> However, it doesn't need to be implemented right now - at present
> dwarf2loc short circutes frame-base, implementing DW_AT_frame_base locally.
I think we've managed to end up in violent agreement. Since right now
the frame base is associated with the unwinder, shall we leave it as
the CFA with a comment saying something like:
/* When we have DWARF-2 debugging information, this should be
DW_AT_frame_base. It should probably be provided by a method
specific to the function's debug information instead of its
unwind type. */
Not sure I got the wording right.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-05-05 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-04 22:07 Mark Kettenis
2003-05-05 3:35 ` Andrew Cagney
2003-05-05 3:42 ` Daniel Jacobowitz
2003-05-05 14:08 ` Andrew Cagney
2003-05-05 14:27 ` Daniel Jacobowitz
2003-05-05 14:52 ` Andrew Cagney
2003-05-05 14:59 ` Daniel Jacobowitz [this message]
2003-05-05 14:11 ` Mark Kettenis
2003-05-05 13:48 ` Mark Kettenis
2003-05-05 14:24 ` Andrew Cagney
2003-05-05 13:52 ` Mark Kettenis
2003-05-05 14:31 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030505145903.GA29766@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox