From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25478 invoked by alias); 1 May 2003 23:26:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25471 invoked from network); 1 May 2003 23:26:58 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 1 May 2003 23:26:58 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19BNSQ-0001vv-00 for ; Thu, 01 May 2003 18:27:18 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19BNS4-00013M-00 for ; Thu, 01 May 2003 19:26:56 -0400 Date: Thu, 01 May 2003 23:26:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [patch rfc] Always disassemble the target Message-ID: <20030501232656.GA4033@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3EAD997B.8050401@redhat.com> <3EB1AC29.3040304@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EB1AC29.3040304@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-05/txt/msg00010.txt.bz2 On Thu, May 01, 2003 at 07:22:17PM -0400, Andrew Cagney wrote: > >2003-04-28 Andrew Cagney > > > > * disasm.c (gdb_disassemble_from_exec): Delete global variable. > > (gdb_disassembly): Make "di" non static, always initialize and > > cleanup. Always use dis_asm_read_memory. > > (gdb_dis_asm_read_memory): Delete function. > > > >Index: testsuite/ChangeLog > >2003-04-28 Andrew Cagney > > > > * gdb.asm/asm-source.exp: Check that the disassm and x/i of a > > variable doesn't give a memory error. > > > > I've checked this in. Thanks a lot for following up on this. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer