From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27002 invoked by alias); 22 Apr 2003 20:22:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26995 invoked from network); 22 Apr 2003 20:22:26 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 22 Apr 2003 20:22:26 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 1984Ho-00054v-00; Tue, 22 Apr 2003 15:22:40 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 1984HX-0001gu-00; Tue, 22 Apr 2003 16:22:23 -0400 Date: Tue, 22 Apr 2003 20:22:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, Jason Molenda Subject: Re: PATCH: Add type_sprint() function to return type in string form Message-ID: <20030422202223.GA6466@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com, Jason Molenda References: <20030418152426.A93348@molenda.com> <20030422032629.GB5033@nevyn.them.org> <3EA57249.5020104@redhat.com> <20030422165455.GA31686@nevyn.them.org> <3EA57BD9.5020502@redhat.com> <20030422173348.GA325@nevyn.them.org> <3EA5961E.3060102@redhat.com> <20030422192827.GA21651@nevyn.them.org> <3EA5A31A.5060504@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EA5A31A.5060504@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-04/txt/msg00412.txt.bz2 On Tue, Apr 22, 2003 at 04:16:26PM -0400, Andrew Cagney wrote: > > >>Sure, but the interface would sux. > > > > > >Then what would you prefer? I have a really negative gut reaction to > >putting dup in the name; it's not duplicating anything. > >type_as_string? > > It is making an xmalloc'ed string duplicate of the type. A duplicate is the same as the original. A string is not the same as a type. > Jason, your choice: > > type_xasprint (char **buf, ...) > > or > > char *type_xstrdup (....); > > Andrew > > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer