From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31800 invoked by alias); 22 Apr 2003 20:35:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31793 invoked from network); 22 Apr 2003 20:35:51 -0000 Received: from unknown (HELO molenda.com) (192.220.74.81) by sources.redhat.com with SMTP; 22 Apr 2003 20:35:51 -0000 Received: (qmail 42453 invoked by uid 19025); 22 Apr 2003 20:35:50 -0000 Date: Tue, 22 Apr 2003 20:35:00 -0000 From: Jason Molenda To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: PATCH: Add type_sprint() function to return type in string form Message-ID: <20030422133550.A40660@molenda.com> References: <20030418152426.A93348@molenda.com> <20030422032629.GB5033@nevyn.them.org> <3EA57249.5020104@redhat.com> <20030422165455.GA31686@nevyn.them.org> <3EA57BD9.5020502@redhat.com> <20030422173348.GA325@nevyn.them.org> <3EA5961E.3060102@redhat.com> <20030422192827.GA21651@nevyn.them.org> <3EA5A31A.5060504@redhat.com> <20030422202223.GA6466@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030422202223.GA6466@nevyn.them.org>; from drow@mvista.com on Tue, Apr 22, 2003 at 04:22:23PM -0400 X-SW-Source: 2003-04/txt/msg00413.txt.bz2 I really don't care about the name of the function. Daniel's reasoning behind type_xasprint makes sense, although I prefer the convenience of just getting the pointer to the xmalloc'ed memory as a return value, in which case type_xstrdup would be more appropriate. Coin toss says... tails - it's type_xasprint. I'll write an updated patch tonight when I get home, and see if I can find a way to elicit the error in the testsuite. Jason