From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10509 invoked by alias); 15 Apr 2003 02:06:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10502 invoked from network); 15 Apr 2003 02:06:30 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 15 Apr 2003 02:06:30 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 195FqJ-0005NL-00; Mon, 14 Apr 2003 21:06:39 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 195Fq7-0007wo-00; Mon, 14 Apr 2003 22:06:27 -0400 Date: Tue, 15 Apr 2003 02:06:00 -0000 From: Daniel Jacobowitz To: Elena Zannoni Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [RFA/TESTSUITE] build schedlock.c on 64-bit platforms Message-ID: <20030415020627.GA30534@nevyn.them.org> Mail-Followup-To: Elena Zannoni , Michael Snyder , gdb-patches@sources.redhat.com References: <16019.15635.929065.664152@localhost.redhat.com> <20030409131329.GA4525@nevyn.them.org> <16021.31692.763468.4182@localhost.redhat.com> <20030410141953.GA10379@nevyn.them.org> <3E96501F.95D6F7DC@redhat.com> <16027.26122.875009.304007@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16027.26122.875009.304007@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-04/txt/msg00302.txt.bz2 On Mon, Apr 14, 2003 at 09:53:14PM -0400, Elena Zannoni wrote: > Michael Snyder writes: > > Daniel Jacobowitz wrote: > > > > > > On Thu, Apr 10, 2003 at 10:12:28AM -0400, Elena Zannoni wrote: > > > > Daniel Jacobowitz writes: > > > > > On Tue, Apr 08, 2003 at 05:20:19PM -0400, Elena Zannoni wrote: > > > > > > > > > > > > I was getting warnings when compiling the test on 64-bit because of the casts. > > > > > > > > > > > > > > > > > > > > Sigh, I was just sloppy writing this one. Does it work if you pass > > > > > &args[i] instead of messing with my_number? That's a little more > > > > > portable. > > > > > > > > > > > > > Ok, how about this? But now get_current_thread in schedlock.exp > > > > doesn't work, because the output has changed. I am not sure I > > > > understand what it should be doing now. There is no way to get the > > > > thread number from the backtraces. > > > > > > Oh, you're right - sorry for the wild goose chase. I think your > > > previous patch with the cast to long is OK then. The test isn't > > > terribly portable but it should be portable enough for our use. > > > > Why don't you just declare 'i' a long and be done with it? > > Daniel? Looks fine to me - portable enough for our purposes. > Index: schedlock.c > =================================================================== > RCS file: /cvs/uberbaum/gdb/testsuite/gdb.threads/schedlock.c,v > retrieving revision 1.2 > diff -u -p -r1.2 schedlock.c > --- schedlock.c 23 Oct 2002 03:22:56 -0000 1.2 > +++ schedlock.c 15 Apr 2003 01:47:34 -0000 > @@ -13,12 +13,15 @@ int main() { > int res; > pthread_t threads[NUM]; > void *thread_result; > - int i; > + long i; > > for (i = 0; i < NUM; i++) > { > args[i] = 1; > - res = pthread_create(&threads[i], NULL, thread_function, (void *)i); > + res = pthread_create(&threads[i], > + NULL, > + thread_function, > + (void *) i); > } > > /* schedlock.exp: last thread start. */ > @@ -29,7 +32,7 @@ int main() { > } > > void *thread_function(void *arg) { > - int my_number = (int) arg; > + int my_number = (long) arg; > int *myp = &args[my_number]; > > /* Don't run forever. Run just short of it :) */ > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer