From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22737 invoked by alias); 9 Apr 2003 13:57:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22730 invoked from network); 9 Apr 2003 13:57:47 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 9 Apr 2003 13:57:47 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 193G5J-00010R-00 for ; Wed, 09 Apr 2003 08:57:53 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 193G58-0000DF-00 for ; Wed, 09 Apr 2003 09:57:42 -0400 Date: Wed, 09 Apr 2003 13:57:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: use MIPS NewABI register names when disassembling NewABI code Message-ID: <20030409135740.GA799@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3E927BCA.1080702@redhat.com> <3E93391F.2050005@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-04/txt/msg00155.txt.bz2 On Wed, Apr 09, 2003 at 12:45:28AM -0300, Alexandre Oliva wrote: > + /* It would be nice if we could bfd_release the previous > + symbol, but we'd need a pointer to its bfd then. */ > + symbol = bfd_make_empty_symbol (info.abfd); I'd rather lose that comment, lest someone be tempted to save a bfd pointer in the right place to let us call bfd_release here. Remember, bfd_release frees its argument and all more recent allocations. Hardly wise in this context... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer