Re: [PATCH] disassembly fixes

[Daniel Jacobowitz <drow@mvista.com>]

On Mon, Apr 07, 2003 at 09:31:08AM -0400, Elena Zannoni wrote:
> Daniel Jacobowitz writes:
>  > On Fri, Apr 04, 2003 at 06:04:48PM -0500, Elena Zannoni wrote:
>  > > 
>  > > A few fixes for the new disassembler. I'll commit in a day or so.
>  > > 
>  > > 2003-04-04  Elena Zannoni  <ezannoni@redhat.com>
>  > > 
>  > > 	* disasm.c (dump_insns):  Move variables inside loop, or they will
>  > >         be freed more than once, causing wild memory corruptions.
>  > > 	(gdb_disassembly): Look for the substring "-thread",
>  > >         instead of "-threads" in the target name, to make sure to find
>  > >         the 'multi-thread' target.  Also, make sure we do the right thing 
>  > >         with the "core" target.
>  > 
>  > While you're in there, any comments on:
>  >   http://sources.redhat.com/ml/gdb/2003-02/msg00153.html
>  > ?
>  > 
> 
> Hmm, yes, I think that logic is a bit screwed up (it came from gdbtk,
> and maybe there it was more appropriate), I have no objections if you
> want to revisit the heuristics.  n hte meantime I would apply these
> changes anyway because disassembly with core files and threaded
> programs just doesn't work at all.

Sounds good to me!

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer