From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32257 invoked by alias); 7 Apr 2003 13:32:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32248 invoked from network); 7 Apr 2003 13:32:25 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 7 Apr 2003 13:32:25 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 192Wje-0005LH-00 for ; Mon, 07 Apr 2003 08:32:30 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 192WjX-0001Jx-00 for ; Mon, 07 Apr 2003 09:32:23 -0400 Date: Mon, 07 Apr 2003 13:32:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] disassembly fixes Message-ID: <20030407133223.GA5011@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <16014.3984.767812.912971@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16014.3984.767812.912971@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-04/txt/msg00113.txt.bz2 On Fri, Apr 04, 2003 at 06:04:48PM -0500, Elena Zannoni wrote: > > A few fixes for the new disassembler. I'll commit in a day or so. > > 2003-04-04 Elena Zannoni > > * disasm.c (dump_insns): Move variables inside loop, or they will > be freed more than once, causing wild memory corruptions. > (gdb_disassembly): Look for the substring "-thread", > instead of "-threads" in the target name, to make sure to find > the 'multi-thread' target. Also, make sure we do the right thing > with the "core" target. While you're in there, any comments on: http://sources.redhat.com/ml/gdb/2003-02/msg00153.html ? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer