From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25187 invoked by alias); 4 Apr 2003 22:25:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25180 invoked from network); 4 Apr 2003 22:25:20 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 4 Apr 2003 22:25:20 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 191Zcc-0004yx-00; Fri, 04 Apr 2003 16:25:18 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 191ZcV-0004t3-00; Fri, 04 Apr 2003 17:25:11 -0500 Date: Fri, 04 Apr 2003 22:25:00 -0000 From: Daniel Jacobowitz To: Elena Zannoni Cc: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA/DWARF2] Fallback unknown language to C Message-ID: <20030404222511.GA18770@nevyn.them.org> Mail-Followup-To: Elena Zannoni , Joel Brobecker , gdb-patches@sources.redhat.com References: <20030312014415.GE958@gnat.com> <20030312145855.GA2699@nevyn.them.org> <16014.1427.560745.693806@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16014.1427.560745.693806@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-04/txt/msg00071.txt.bz2 On Fri, Apr 04, 2003 at 05:22:11PM -0500, Elena Zannoni wrote: > Daniel Jacobowitz writes: > > On Tue, Mar 11, 2003 at 05:44:15PM -0800, Joel Brobecker wrote: > > > I am hearing the first rumors of 5.4, I think it would be nice to have > > > the following change in. It's a followup on a remark made in this > > > message: > > > > > > http://sources.redhat.com/ml/gdb/2003-02/msg00533.html > > > > > > (GDB does not work very well when the language is unknown) > > > > > > 2003-03-11 J. Brobecker > > > > > > * dwarf2read.c (set_cu_language): Fall the language back to C > > > if it is unsupported. > > > > > > Ok to commit? > > > > I agree with the remark, but not the method. Does anyone see an > > advantage to the unk_* methods calling error() instead of silently > > defaulting to the C versions? That seems more appropriate to me. > > > > > > I don't like too much the idea of making the unk_lang functions > default silently to C. These functions, in my mind, also serve as a > kind of error checking in case the language settings get screwed up > during debugging. Maybe the solution is to provide a > 'partial_language' set of functions which do the bare minimum. > > The thing I missed from the various postings was a real reason of why > the behavior changed. I guess that for stabs we didn't detect any of > these languages at all and we defaulted to C from > set_initial_language(). Yeah, I think that's what was happening. If you prefer Joel's method I certainly don't object. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer