From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17083 invoked by alias); 3 Apr 2003 13:17:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17075 invoked from network); 3 Apr 2003 13:17:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 3 Apr 2003 13:17:40 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h33DHee21789 for ; Thu, 3 Apr 2003 08:17:40 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h33DHdW09762 for ; Thu, 3 Apr 2003 08:17:39 -0500 Received: from cygbert.vinschen.de (vpn50-13.rdu.redhat.com [172.16.50.13]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h33DHb519012 for ; Thu, 3 Apr 2003 05:17:38 -0800 Received: (from corinna@localhost) by cygbert.vinschen.de (8.11.6/8.9.3/Linux sendmail 8.9.3) id h33DHYF03760 for gdb-patches@sources.redhat.com; Thu, 3 Apr 2003 15:17:34 +0200 Date: Thu, 03 Apr 2003 13:17:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Remove calls to inside_entry_file Message-ID: <20030403131734.GN18138@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <3E84E8B4.7000502@redhat.com> <20030401153125.GY18138@cygbert.vinschen.de> <3E89B2AA.5060304@redhat.com> <20030401161824.GA18138@cygbert.vinschen.de> <3E89BFE4.7020500@redhat.com> <20030401170307.GD18138@cygbert.vinschen.de> <3E89CCC9.7040908@redhat.com> <20030401195832.GA10202@nevyn.them.org> <20030402092741.GA26480@cygbert.vinschen.de> <3E8B1178.6050605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E8B1178.6050605@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-04/txt/msg00050.txt.bz2 On Wed, Apr 02, 2003 at 11:36:08AM -0500, Andrew Cagney wrote: > I'm beginning to think that reverting some of the original change: > > RFC: Mostly kill FRAME_CHAIN_VALID, add user knob > http://sources.redhat.com/ml/gdb-patches/2002-12/msg00683.html > > might be the best option. What about moving this: > > > + > > + /* If the architecture has a custom FRAME_CHAIN_VALID, call it > now. */ > > + if (FRAME_CHAIN_VALID_P ()) > > + return FRAME_CHAIN_VALID (fp, fi); > > to before this: > > + /* If we're already inside the entry function for the main objfile, > then it > + isn't valid. */ > + if (inside_entry_func (get_frame_pc (fi))) > + return 0; > + > + /* If we're inside the entry file, it isn't valid. */ > + /* NOTE/drow 2002-12-25: should there be a way to disable this check? It > + assumes a single small entry file, and the way some debug readers > (e.g. > + dbxread) figure out which object is the entry file is somewhat > hokey. */ > + if (inside_entry_file (frame_pc_unwind (fi))) > + return 0; > + > + /* If we want backtraces to stop at main, and we're inside main, then it > + isn't valid. */ > + if (!backtrace_below_main && inside_main_func (get_frame_pc (fi))) > + return 0; > > That more closely resembles the original behavior. I think that's pretty much ok. Old targets in need of one of these functions can still call it from (deprecated_)frame_chain_valid(). Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc. mailto:vinschen@redhat.com