From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5291 invoked by alias); 1 Apr 2003 21:38:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5283 invoked from network); 1 Apr 2003 21:38:41 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 1 Apr 2003 21:38:41 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 190TSc-0006oL-00; Tue, 01 Apr 2003 15:38:26 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 190TSX-0003MW-00; Tue, 01 Apr 2003 16:38:21 -0500 Date: Tue, 01 Apr 2003 21:38:00 -0000 From: Daniel Jacobowitz To: Adam Fedor Cc: Andrew Cagney , David Carlton , GDB Patches Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5] Message-ID: <20030401213821.GA12857@nevyn.them.org> Mail-Followup-To: Adam Fedor , Andrew Cagney , David Carlton , GDB Patches References: <99FCC0F2-63CE-11D7-9F75-000A277AC1A4@doc.com> <3E88DDD0.2090603@redhat.com> <3E8910F5.2090507@doc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E8910F5.2090507@doc.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-04/txt/msg00024.txt.bz2 On Mon, Mar 31, 2003 at 09:09:25PM -0700, Adam Fedor wrote: > > > Andrew Cagney wrote: > > > > > >Hmm, good catch. Any reason for the unknown language demangler to not > >just do c++ demangling? > > > > OK. Here I've add java_demangle and now ukn_lang_demangle uses > cplus_demangle. I think you've satisfied all my concerns. Since Andrew and David both liked this patch, it's OK to check in now. Please fix one thing for me: there are two switch statements below from which you remove all cases except for default. Please remove the switches entirely. > @@ -153,13 +153,9 @@ maintenance_demangle (char *args, int fr > { > switch (current_language->la_language) > { > - case language_objc: > - /* Commented out until ObjC handling is enabled. */ > - /* demangled = objc_demangle (args); */ > - /* break; */ > - case language_cplus: > default: > - demangled = cplus_demangle (args, DMGL_ANSI | DMGL_PARAMS); > + demangled = language_demangle (current_language, args, > + DMGL_ANSI | DMGL_PARAMS); > break; > } > if (demangled != NULL) > Index: utils.c > =================================================================== > RCS file: /cvs/src/src/gdb/utils.c,v > retrieving revision 1.98 > diff -u -p -r1.98 utils.c > --- utils.c 26 Feb 2003 14:35:19 -0000 1.98 > +++ utils.c 1 Apr 2003 04:01:30 -0000 > @@ -2300,18 +2300,9 @@ fprintf_symbol_filtered (struct ui_file > { > switch (lang) > { > - case language_cplus: > - demangled = cplus_demangle (name, arg_mode); > - break; > - case language_java: > - demangled = cplus_demangle (name, arg_mode | DMGL_JAVA); > - break; > - case language_objc: > - /* Commented out until ObjC handling is enabled. */ > - /*demangled = objc_demangle (name); */ > - /*break; */ > default: > - demangled = NULL; > + demangled = language_demangle (language_def (lang), > + name, arg_mode); > break; > } > fputs_filtered (demangled ? demangled : name, stream); -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer