From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20485 invoked by alias); 27 Mar 2003 17:48:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20478 invoked from network); 27 Mar 2003 17:48:54 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 27 Mar 2003 17:48:54 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18ydOG-00038G-00; Thu, 27 Mar 2003 13:50:20 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18ybUg-0006Eu-00; Thu, 27 Mar 2003 12:48:50 -0500 Date: Thu, 27 Mar 2003 17:48:00 -0000 From: Daniel Jacobowitz To: nickc@redhat.com Cc: cgd@broadcom.com, gdb-patches@sources.redhat.com Subject: Re: SIM: Add support for Intel iWMMXt processor Message-ID: <20030327174850.GA9143@nevyn.them.org> Mail-Followup-To: nickc@redhat.com, cgd@broadcom.com, gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-03/txt/msg00552.txt.bz2 On Thu, Mar 27, 2003 at 09:31:49AM -0800, cgd@broadcom.com wrote: > At Thu, 27 Mar 2003 17:12:56 +0000 (UTC), "Nick Clifton" wrote: > > I am applying the attached patch below to add support for Intel's > > iWMMXt processor to the ARM simulator. (The old armulator based > > one, not the cgen based one). > > I took a look at this patch, just to see what was inside, and noticed > definition and uses of __IWMMXT__. Is it "the right thing" to be > defining and using a macro name which (i believe 8-) is in the > implementation namespace? These patches also contain #if 0'd code; why introduce _new_ dead code? I believe most of the #ifdefs can be safely removed. I notice you change one thing marked as "used by the FPE code" without conditioning it on iWMMXt (search for 0x91). Is that correct? I understand you're eager to get this stuff out, but please pay attention to what you're committing. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer