From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29786 invoked by alias); 18 Mar 2003 03:46:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29644 invoked from network); 18 Mar 2003 03:46:31 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 18 Mar 2003 03:46:31 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 28EC2D34B8; Mon, 17 Mar 2003 19:46:34 -0800 (PST) Date: Tue, 18 Mar 2003 03:46:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA/RFC] disable-nls if msgfmt could not be found Message-ID: <20030318034633.GO16507@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="O98KdSgI27dgYlM5" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2003-03/txt/msg00389.txt.bz2 --O98KdSgI27dgYlM5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1427 Hello, I hope I am sending this to the right list... Some users building GDB on systems where msgfmt is not available were blocked when the build failed (in bfd, and probably another subdir that I can't remember). See http://sources.redhat.com/ml/gdb/2003-02/msg00310.html. Instead of adding the checks in each subdir, I thought that it might be better to do the check for msgfmt in the toplevel configure, and pass --disable-nls to the subdir configure commands if not found. The following patches tries to do this, and has been tested on a hpux box where msgfmt is missing, and on a linux machine where msgfmt was available. Ideally, we want to do the check for msgfmt only if --disable-nls was not already specified. However, the only consequence of not checking for the presence of --disable-nls is that we might have more than one --disable/enable-nls switches on the subdir configure commands. I think it will be ok, since I've placed the --disable-nls at the end so it should overide the user's switch. An AC_MSG_WARN may also have been nice, but I decided against it because seeing a warning even when the user has specified --disable-nls would seem strange... Would the following change be acceptable for inclusion? 2003-03-17 J. Brobecker * configure.in: Add check for msgfmt, configure subdir with --disable-nls if not found. * configure: Regenerate. -- Joel --O98KdSgI27dgYlM5 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="configure.in.diff" Content-length: 830 Index: configure.in =================================================================== RCS file: /cvs/src/src/configure.in,v retrieving revision 1.158 diff -c -3 -r1.158 configure.in *** configure.in 12 Mar 2003 20:47:07 -0000 1.158 --- configure.in 18 Mar 2003 03:43:33 -0000 *************** *** 1824,1829 **** --- 1824,1838 ---- *) gxx_include_dir=${with_gxx_include_dir} ;; esac + # Check that msgfmt can be found in the PATH, or configure with + # --disable-nls to avoid a build failure. + AC_CHECK_PROG(MSGFMT, msgfmt, msgfmt, ) + if [ test "x$MSGFMT" = "x" ]; then + build_configargs="${build_configargs} --disable-nls" + host_configargs="${host_configargs} --disable-nls" + target_configargs="${target_configargs} --disable-nls" + fi + FLAGS_FOR_TARGET= case " $target_configdirs " in *" newlib "*) --O98KdSgI27dgYlM5--