From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6265 invoked by alias); 15 Mar 2003 20:39:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6079 invoked from network); 15 Mar 2003 20:39:21 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 15 Mar 2003 20:39:21 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id h2FKdFpE000295; Sat, 15 Mar 2003 21:39:15 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id h2FKdFci000334; Sat, 15 Mar 2003 21:39:15 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id h2FKdEnO000331; Sat, 15 Mar 2003 21:39:14 +0100 (CET) Date: Sat, 15 Mar 2003 20:39:00 -0000 Message-Id: <200303152039.h2FKdEnO000331@elgar.kettenis.dyndns.org> From: Mark Kettenis To: drow@mvista.com CC: gdb-patches@sources.redhat.com In-reply-to: <20030314183529.GA18511@nevyn.them.org> (message from Daniel Jacobowitz on Fri, 14 Mar 2003 13:35:29 -0500) Subject: Re: RFC: threads PREPARE_TO_PROCEED patch References: <20030313233251.GA22466@nevyn.them.org> <86of4d7tle.fsf@elgar.kettenis.dyndns.org> <20030314183529.GA18511@nevyn.them.org> X-SW-Source: 2003-03/txt/msg00342.txt.bz2 Date: Fri, 14 Mar 2003 13:35:29 -0500 From: Daniel Jacobowitz > I'm not quite sure whether changing the gdbarch default is a good > idea, but replacing lin_lwp_prepare_to_proceed with > generic_prepare_to_proceed has been the intention all along. Well, let me describe the problem I'm trying to solve; I'd like your opinion on how to approach it. When using gdbserver, we need to have generic_prepare_to_proceed. Not the lin_lwp version, and not the "default" one from arch-utils. The former won't work and the latter doesn't do enough. So cross debuggers need to pick this up. OK, but generic_prepare_to_proceed() is perfectly usable on a native GNU/Linux GDB too, isn't it? Note that this is a property of the target. Not of the architecture. I'm not sure PREPARE_TO_PROCEED belongs in gdbarch at all. It's only defined by Mach3, HP/UX, and Linux; it's undefined for x86-64-linux (why???). I could set it in all the Linux gdbarch init functions that I care about, but that doesn't seem like much of a solution. It seems to be a property of the OS to me. In its current incarnation, gdbarch does includes details of both the architecture (ISA) and the OS (OS/ABI). So gdbarch seems to be the correct place for PREPARE_TO_PROCEED to me. So yes, I think you should add it to all relevant Linux gdbarch init functions. Mark