From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5253 invoked by alias); 12 Mar 2003 14:59:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5242 invoked from network); 12 Mar 2003 14:59:00 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 12 Mar 2003 14:59:00 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18t9aS-00052K-00; Wed, 12 Mar 2003 11:00:16 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18t7h1-0000iz-00; Wed, 12 Mar 2003 09:58:55 -0500 Date: Wed, 12 Mar 2003 14:59:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/DWARF2] Fallback unknown language to C Message-ID: <20030312145855.GA2699@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20030312014415.GE958@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030312014415.GE958@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-03/txt/msg00276.txt.bz2 On Tue, Mar 11, 2003 at 05:44:15PM -0800, Joel Brobecker wrote: > I am hearing the first rumors of 5.4, I think it would be nice to have > the following change in. It's a followup on a remark made in this > message: > > http://sources.redhat.com/ml/gdb/2003-02/msg00533.html > > (GDB does not work very well when the language is unknown) > > 2003-03-11 J. Brobecker > > * dwarf2read.c (set_cu_language): Fall the language back to C > if it is unsupported. > > Ok to commit? I agree with the remark, but not the method. Does anyone see an advantage to the unk_* methods calling error() instead of silently defaulting to the C versions? That seems more appropriate to me. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer