From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17270 invoked by alias); 10 Mar 2003 19:04:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17260 invoked from network); 10 Mar 2003 19:04:02 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (209.53.16.215) by 172.16.49.205 with SMTP; 10 Mar 2003 19:04:02 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 45D1DD34B6; Mon, 10 Mar 2003 11:03:48 -0800 (PST) Date: Mon, 10 Mar 2003 19:04:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/PING] Fix a small memory leak in bpstat_stop_status Message-ID: <20030310190348.GF967@gnat.com> References: <20021212104058.GL25575@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021212104058.GL25575@gnat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-03/txt/msg00225.txt.bz2 Hello, Can somebody have a look at this patch please (2nd ping)? Granted, it is not a very important patch, it "only" fixes a small memory leak, but I believe the change is very localized, so easy to review. Thanks! On Thu, Dec 12, 2002 at 11:40:58AM +0100, Joel Brobecker wrote: > This is a followup on a thread that I started, archived at: > http://sources.redhat.com/ml/gdb-patches/2002-12/msg00358.html > > Basically, I extracted the part that fixed a small memory leak, and > tested it separately, as the other part of the patch is likely to be > superseeded by another patch submitted by Klee Dienes. > > 2002-12-12 Joel Brobecker > > * breakpoint.c (bpstat_stop_status): Fix a small memory leak. > > No regressions on x86-linux. > > Ok to apply? > -- > Joel > Index: breakpoint.c > =================================================================== > RCS file: /cvs/src/src/gdb/breakpoint.c,v > retrieving revision 1.100 > diff -c -3 -p -r1.100 breakpoint.c > *** breakpoint.c 4 Dec 2002 04:53:13 -0000 1.100 > --- breakpoint.c 12 Dec 2002 10:21:53 -0000 > *************** bpstat_stop_status (CORE_ADDR *pc, int n > *** 2763,2771 **** > /* We will stop here */ > if (b->disposition == disp_disable) > b->enable_state = bp_disabled; > - bs->commands = copy_command_lines (b->commands); > if (b->silent) > bs->print = 0; > if (bs->commands && > (STREQ ("silent", bs->commands->line) || > (xdb_commands && STREQ ("Q", bs->commands->line)))) > --- 2767,2775 ---- > /* We will stop here */ > if (b->disposition == disp_disable) > b->enable_state = bp_disabled; > if (b->silent) > bs->print = 0; > + bs->commands = b->commands; > if (bs->commands && > (STREQ ("silent", bs->commands->line) || > (xdb_commands && STREQ ("Q", bs->commands->line)))) > *************** bpstat_stop_status (CORE_ADDR *pc, int n > *** 2773,2778 **** > --- 2777,2783 ---- > bs->commands = bs->commands->next; > bs->print = 0; > } > + bs->commands = copy_command_lines (bs->commands); > } > } > /* Print nothing for this entry if we dont stop or if we dont print. */ -- Joel