From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28541 invoked by alias); 28 Feb 2003 15:19:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28534 invoked from network); 28 Feb 2003 15:19:06 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 28 Feb 2003 15:19:06 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18ooBE-00064x-00 for ; Fri, 28 Feb 2003 11:20:16 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18omHw-00061j-00 for ; Fri, 28 Feb 2003 10:19:04 -0500 Date: Fri, 28 Feb 2003 15:19:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Modify gdb/Makefile.in to build observer.c Message-ID: <20030228151904.GA23109@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030228073413.GE6112@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030228073413.GE6112@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00807.txt.bz2 On Thu, Feb 27, 2003 at 11:34:13PM -0800, Joel Brobecker wrote: > I made the following changes in order to have observer.[hc] built > in GDB. > > Since this unit is currently unused in GDB, I have considered not > linking in this observer.o. However, I think I've seen another recent > patch that is just about ready to benefit from this framework. So I > discarded this idea. > > There is one variable that I don't quite understand; it's > HFILES_NO_SRCDIR. The comment ("Header files that need to have srcdir > added", sic) did not help me, so I wasn't sure that observer.h does > not need to be added to this list. Let me know if it should. HFILES_NO_SRCDIR is only used for make TAGS, and that's been neglected for a while now - I'd say, don't worry about it. > 2003-02-27 J. Brobecker > > * Makefile.in: Add rules to build and link in observer.o. > > Ok to apply? Since Andrew's already indicated he wants this linked in, and since I actually have another bug that this will make much easier to solve, please go ahead. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer