Re: [Patch] correctly configure wcwidth in readline

Daniel Jacobowitz
2003-02-26T17:51:46Z

On Wed, Feb 26, 2003 at 12:44:22PM -0500, Kris Warkentin wrote:
> Here's what seems to me to be a more elegant solution. In aclocal.m4, I
> just define the obj as wcwidth.o and then the Makefile will either have it
> or not.
>
> cheers,

> < AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH))
> ---
> > AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH),
> AC_SUBST(WCWIDTH_OBJ,wcwidth.o))

[Always use unified or context diffs, please]

Did you try this on a host with wcwidth? I don't think it'll work
right; I have the feeling that a conditional AC_SUBST can leave
@WCWIDTH_OBJ@ in the makefile.

> ----- Original Message -----
> From: "Daniel Jacobowitz" <drow@mvista.com>
> To: "Kris Warkentin" <kewarken@qnx.com>
> Cc: <gdb-patches@sources.redhat.com>
> Sent: Wednesday, February 26, 2003 12:37 PM
> Subject: Re: [Patch] correctly configure wcwidth in readline
>
>
> > On Wed, Feb 26, 2003 at 12:35:16PM -0500, Kris Warkentin wrote:
> > > > Something like this needs to go through the maintainers of
> > > > bash/readline first.
> > >
> > > The problem is that I couldn't get any response from the bash/readline
> > > maintainers. I mailed the mailing lists and the owner and got no
> response.
> > > I also noticed that there is a readline/ChangeLog.gdb file with local
> > > changes so I figured if I wasn't getting any lovin' from readline, I
> might
> > > at least get it merged into the gdb tree.
> >
> > Blech. Yeah, in that case I think this sort of patch is acceptable
> > (that's not a comment on the actual patch - I don't know much about
> > readline, I leave that to Elena :)
> >
> > --
> > Daniel Jacobowitz
> > MontaVista Software Debian GNU/Linux Developer
> >
>
>

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer