Re: [Patch] correctly configure wcwidth in readline

Kris Warkentin
2003-02-26T17:44:17Z

Here's what seems to me to be a more elegant solution. In aclocal.m4, I
just define the obj as wcwidth.o and then the Makefile will either have it
or not.

cheers,

Kris

$ cvs diff Makefile.in aclocal.m4
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/readline/Makefile.in,v
retrieving revision 1.4
diff -r1.4 Makefile.in
88a89,90
> WCWIDTH_OBJ = @WCWIDTH_OBJ@
>
101c103
< $(srcdir)/mbutil.c
---
> $(srcdir)/mbutil.c $(srcdir)/support/wcwidth.c
114c116,117
< text.o nls.o misc.o compat.o xmalloc.o $(HISTOBJ) $(TILDEOBJ)
---
> text.o nls.o misc.o compat.o xmalloc.o $(HISTOBJ) $(TILDEOBJ) \
> $(WCWIDTH_OBJ)
148a152,155
>
> wcwidth.o: $(srcdir)/support/wcwidth.c
> $(RM) $@
> $(CC) $(CCFLAGS) -c $(srcdir)/support/wcwidth.c
Index: aclocal.m4
===================================================================
RCS file: /cvs/src/src/readline/aclocal.m4,v
retrieving revision 1.4
diff -r1.4 aclocal.m4
1656c1656
< AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH))
---
> AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH),
AC_SUBST(WCWIDTH_OBJ,wcwidth.o))

----- Original Message -----
From: "Daniel Jacobowitz" <drow@mvista.com>
To: "Kris Warkentin" <kewarken@qnx.com>
Cc: <gdb-patches@sources.redhat.com>
Sent: Wednesday, February 26, 2003 12:37 PM
Subject: Re: [Patch] correctly configure wcwidth in readline

> On Wed, Feb 26, 2003 at 12:35:16PM -0500, Kris Warkentin wrote:
> > > Something like this needs to go through the maintainers of
> > > bash/readline first.
> >
> > The problem is that I couldn't get any response from the bash/readline
> > maintainers. I mailed the mailing lists and the owner and got no
response.
> > I also noticed that there is a readline/ChangeLog.gdb file with local
> > changes so I figured if I wasn't getting any lovin' from readline, I
might
> > at least get it merged into the gdb tree.
>
> Blech. Yeah, in that case I think this sort of patch is acceptable
> (that's not a comment on the actual patch - I don't know much about
> readline, I leave that to Elena :)
>
> --
> Daniel Jacobowitz
> MontaVista Software Debian GNU/Linux Developer
>