Re: PING: [RFA] Runtime Dwarf2 CFI engine cleanup

Andrew Cagney
2003-02-26T18:20:34Z

>
>
> I don't think that the way you're selecting objfiles to unload is ideal
> - you're duplicating logic from objfile_purge_solibs. We need a more
> general hook to free objfile-specific information. However, I believe
> that can be addressed separately, and this will definitely fix some
> crashes as-is and not introduce any new ones.
>
> I don't have any problem with linking dwarf2cfi.o in for all targets.
> Let's sit on this for another day and see if anyone else objects, and
> then you can commit it.

A quick look at the bigger picture reveals:

- the underlying code needs to be fixed before it is linked into all
targets.

- if it needs to be modified of changes in another part of gdb then it
should use an observer. It should not introduce another hack.

You'll note that Joel and I are currently working through this. Yes it
means that the posted patch doesn't go in. It also means that GDB is
that bit more (not less) maintainable.

> You made a line in Makefile.in too wide; please fix that before you
> check it in.
>
> [List: my assumption in approving this is that the dwarf2cfi support is
> not part of the dwarf2 reader, so I'm not stepping on anyone's toes.
> If you disagree, please tell me so.]

Puzzled expression.

Andrew