From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30628 invoked by alias); 26 Feb 2003 17:51:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30619 invoked from network); 26 Feb 2003 17:51:45 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 26 Feb 2003 17:51:45 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18o7bp-0001re-00; Wed, 26 Feb 2003 13:52:53 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18o5iY-00040J-00; Wed, 26 Feb 2003 12:51:42 -0500 Date: Wed, 26 Feb 2003 17:51:00 -0000 From: Daniel Jacobowitz To: Kris Warkentin Cc: gdb-patches@sources.redhat.com Subject: Re: [Patch] correctly configure wcwidth in readline Message-ID: <20030226175141.GA15347@nevyn.them.org> Mail-Followup-To: Kris Warkentin , gdb-patches@sources.redhat.com References: <00d101c2ddbd$6d3bfac0$0202040a@catdog> <20030226173758.GA14836@nevyn.them.org> <00e901c2ddbe$b23815e0$0202040a@catdog> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00e901c2ddbe$b23815e0$0202040a@catdog> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00719.txt.bz2 On Wed, Feb 26, 2003 at 12:44:22PM -0500, Kris Warkentin wrote: > Here's what seems to me to be a more elegant solution. In aclocal.m4, I > just define the obj as wcwidth.o and then the Makefile will either have it > or not. > > cheers, > < AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH)) > --- > > AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH), > AC_SUBST(WCWIDTH_OBJ,wcwidth.o)) [Always use unified or context diffs, please] Did you try this on a host with wcwidth? I don't think it'll work right; I have the feeling that a conditional AC_SUBST can leave @WCWIDTH_OBJ@ in the makefile. > ----- Original Message ----- > From: "Daniel Jacobowitz" > To: "Kris Warkentin" > Cc: > Sent: Wednesday, February 26, 2003 12:37 PM > Subject: Re: [Patch] correctly configure wcwidth in readline > > > > On Wed, Feb 26, 2003 at 12:35:16PM -0500, Kris Warkentin wrote: > > > > Something like this needs to go through the maintainers of > > > > bash/readline first. > > > > > > The problem is that I couldn't get any response from the bash/readline > > > maintainers. I mailed the mailing lists and the owner and got no > response. > > > I also noticed that there is a readline/ChangeLog.gdb file with local > > > changes so I figured if I wasn't getting any lovin' from readline, I > might > > > at least get it merged into the gdb tree. > > > > Blech. Yeah, in that case I think this sort of patch is acceptable > > (that's not a comment on the actual patch - I don't know much about > > readline, I leave that to Elena :) > > > > -- > > Daniel Jacobowitz > > MontaVista Software Debian GNU/Linux Developer > > > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer