From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16020 invoked by alias); 26 Feb 2003 17:26:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16009 invoked from network); 26 Feb 2003 17:26:01 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 26 Feb 2003 17:26:01 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18o7Cq-0001nd-00; Wed, 26 Feb 2003 13:27:04 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18o5JZ-0003gE-00; Wed, 26 Feb 2003 12:25:53 -0500 Date: Wed, 26 Feb 2003 17:26:00 -0000 From: Daniel Jacobowitz To: Michal Ludvig Cc: GDB Patches Subject: Re: [RFA] Dwarf2CFI fix Message-ID: <20030226172553.GA14094@nevyn.them.org> Mail-Followup-To: Michal Ludvig , GDB Patches References: <3E5CF5F5.10300@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E5CF5F5.10300@suse.cz> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00715.txt.bz2 On Wed, Feb 26, 2003 at 06:14:29PM +0100, Michal Ludvig wrote: > Hi all, > my code in dwarf2cfi.c assumed that CIE and FDE entries in .eh_frame are > always in the chain CIE, FDE, FDE, ..., CIE, FDE, ... > where every FDE refers to the precedent CIE. Unfortunately this is not > alway the case. Linker (?) sometimes optimizes things in a way that the > assumption isn't true anymore. This patch addresses the problem. > > OK to commit? Head and 5.3? > 2003-02-26 Michal Ludvig > > * dwarf2cfi.c (parse_frame_info): It's not true that FDEs > always refer to the last CIE. We must deal with such a > situation. > * dwarf2cfi.h ( Either you're missing a bit of a patch or you're missing a bit of a changelog. And there's no changelog entry for struct eh_frame either. > diff -upr gdb-upto-08/dwarf2cfi.c gdb/dwarf2cfi.c > --- gdb-upto-08/dwarf2cfi.c 2003-02-26 10:20:02.000000000 +0100 > +++ gdb/dwarf2cfi.c 2003-02-26 17:17:30.000000000 +0100 > @@ -50,6 +50,10 @@ struct cie_unit > char *data; > unsigned int data_length; > > + /* This field is 1 for CIE from .eh_frame > + and 0 for one from .debug_frame. */ Formatting: don't wrap that early, and two spaces after a period. The patch itself looks OK. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer