From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31335 invoked by alias); 26 Feb 2003 16:54:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31320 invoked from network); 26 Feb 2003 16:54:58 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 26 Feb 2003 16:54:58 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18o6is-0001k9-00; Wed, 26 Feb 2003 12:56:06 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18o4pZ-0003Vg-00; Wed, 26 Feb 2003 11:54:53 -0500 Date: Wed, 26 Feb 2003 16:54:00 -0000 From: Daniel Jacobowitz To: Kris Warkentin Cc: gdb-patches@sources.redhat.com Subject: Re: [Patch] correctly configure wcwidth in readline Message-ID: <20030226165452.GA13402@nevyn.them.org> Mail-Followup-To: Kris Warkentin , gdb-patches@sources.redhat.com References: <008501c2ddb6$b33de6c0$0202040a@catdog> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <008501c2ddb6$b33de6c0$0202040a@catdog> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00709.txt.bz2 On Wed, Feb 26, 2003 at 11:47:07AM -0500, Kris Warkentin wrote: > I have attached a patch that correctly deals with the absence of a wcwidth() > function by building support/wcwidth.c and linking it into libreadline. > Oddly enough, the HAVE_WCWIDTH check fails on other systems too (ie. Cygwin) > but causes no problem since wcwidth() gets picked up elsewhere. On QNX > Neutrino, however, we're actually missing wcwidth() so we get undefined > references. What is the procedure for regenerating configure scripts? > Should I regenerate it here and commit it or do you have a certain person > who does it under a specific environment? Kris, from MAINTAINERS: readline/ Master version: ftp://ftp.cwru.edu/pub/bash/ Elena Zannoni ezannoni@redhat.com Host maintainers (host dependant parts) (but get your changes into the master version) Something like this needs to go through the maintainers of bash/readline first. Yes, normally you regenerate any generated files when checking in a patch. > + HAVE_WCWIDTH = @HAVE_WCWIDTH@ > + > + ifeq ($(HAVE_WCWIDTH), no) > + WCWIDTH_SRC = $(srcdir)/support/wcwidth.c > + WCWIDTH_OBJ = wcwidth.o > + endif > + Can't do that. It's a GNU-make-ism. You have to move more of the logic to configure. > + > + ifeq ($(HAVE_WCWIDTH), no) > + $(WCWIDTH_OBJ): $(WCWIDTH_SRC) > + $(RM) $@ > + $(CC) $(CCFLAGS) -c $(WCWIDTH_SRC) > + endif That should probably be an unconditional rule, a la: wcwidth.o: $(srcdir)/support/wcwidth.c $(RM) $@ $(CC) $(CCFLAGS) -c $(srcdir)/support/wcwidth.c -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer